From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFBCC6FA8E for ; Fri, 23 Sep 2022 11:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230479AbiIWLN2 (ORCPT ); Fri, 23 Sep 2022 07:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbiIWLN0 (ORCPT ); Fri, 23 Sep 2022 07:13:26 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C31C81332E4; Fri, 23 Sep 2022 04:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zfgAtGE1lzX9cKdfzAVSb8jixMZFgP1pDMu4gWZzZHk=; b=Aceuu38oHTVA5CFZWx2oP+KXGT XezfqgfXSkFakEfdz/3LwuygiHo3V15hhuBPQS170VUkaHE1bG5ZV1PzU9o/DFGvmJinwV1eNl3Oq rGbsOzCebKqKL3lGJXLzQrJIvbvRLYnkBVPHZVFzy4WrnqOlZZnpcQOoYmUD87Bd1/O3tMq+/O0EK 1IQ1HZ4YRymL+zTfhr3XCU/r50Hd/OH9ggDqL/+pLY3i1QbagUDCd+gabWy2DsQypRiaWsw1LqXPY W49KwuoTl+mh0gomtmls5Z/eytm5BcFPp2Ely9KrdoGMO+EoiMpKESbjx6l6eWfUPjP3RWwGdmefr C3j9c/5g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1obgcL-00FCci-AK; Fri, 23 Sep 2022 11:13:13 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5FB7B3001FD; Fri, 23 Sep 2022 13:13:12 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 222612BC047C3; Fri, 23 Sep 2022 13:13:12 +0200 (CEST) Date: Fri, 23 Sep 2022 13:13:12 +0200 From: Peter Zijlstra To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , "Paul E . McKenney" , Boqun Feng , "H . Peter Anvin" , Paul Turner , linux-api@vger.kernel.org, Christian Brauner , Florian Weimer , David.Laight@aculab.com, carlos@redhat.com, Peter Oskolkov , Alexander Mikhalitsyn Subject: Re: [PATCH v4 03/25] rseq: Extend struct rseq with numa node id Message-ID: References: <20220922105941.237830-1-mathieu.desnoyers@efficios.com> <20220922105941.237830-4-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922105941.237830-4-mathieu.desnoyers@efficios.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2022 at 06:59:18AM -0400, Mathieu Desnoyers wrote: > diff --git a/include/trace/events/rseq.h b/include/trace/events/rseq.h > index a04a64bc1a00..6bd442697354 100644 > --- a/include/trace/events/rseq.h > +++ b/include/trace/events/rseq.h > @@ -16,13 +16,15 @@ TRACE_EVENT(rseq_update, > > TP_STRUCT__entry( > __field(s32, cpu_id) > + __field(s32, node_id) > ), > > TP_fast_assign( > __entry->cpu_id = raw_smp_processor_id(); > + __entry->node_id = cpu_to_node(raw_smp_processor_id()); Very minor nit: perhaps: _entry->node_id = cpu_to_node(__entry->cpu_id); just in case it does a reload and finds a different value. > ),