From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] minmax: clamp more efficiently by avoiding extra comparison
Date: Fri, 23 Sep 2022 18:12:37 +0300 [thread overview]
Message-ID: <Yy3M5Urqiz8jnIYe@smile.fi.intel.com> (raw)
In-Reply-To: <CAHmME9p+SKTHzniw=TsC=vnQsyCuBa08+LcK-CsFcjA58K+ifA@mail.gmail.com>
On Fri, Sep 23, 2022 at 12:48:48PM +0200, Jason A. Donenfeld wrote:
> On Fri, Sep 23, 2022 at 12:40 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
...
> both for the old code and for the new code, the result of lo>hi is
> total nonsense:
Exactly and my point is to add at least compile-time check for constants.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-23 15:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:06 Jason A. Donenfeld
2022-09-23 10:35 ` Andy Shevchenko
2022-09-23 10:40 ` Jason A. Donenfeld
2022-09-23 10:48 ` Jason A. Donenfeld
2022-09-23 15:12 ` Andy Shevchenko [this message]
2022-09-23 15:13 ` Jason A. Donenfeld
2022-09-23 15:40 ` [PATCH v2] " Jason A. Donenfeld
2022-09-23 16:41 ` Kees Cook
2022-09-23 16:42 ` Jason A. Donenfeld
2022-09-23 16:53 ` Andy Shevchenko
2022-09-23 16:54 ` Jason A. Donenfeld
2022-09-23 19:47 ` Kees Cook
2022-09-23 22:54 ` Andrew Morton
2022-09-24 0:02 ` Kees Cook
2022-09-24 10:37 ` Jason A. Donenfeld
2022-09-25 16:29 ` Andrew Morton
2022-09-26 10:00 ` Andy Shevchenko
2022-09-26 12:23 ` Jason A. Donenfeld
2022-09-26 13:34 ` [PATCH v3 1/2] minmax: sanity check constant bounds when clamping Jason A. Donenfeld
2022-09-26 13:34 ` [PATCH v3 2/2] minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld
2022-09-26 18:30 ` Kees Cook
2022-09-26 21:33 ` Jason A. Donenfeld
2022-09-26 13:46 ` [PATCH v3 1/2] minmax: sanity check constant bounds when clamping Andy Shevchenko
2022-09-26 18:26 ` Kees Cook
2022-10-04 13:41 ` Jason A. Donenfeld
2022-10-04 14:39 ` Kees Cook
2022-10-04 15:01 ` Jason A. Donenfeld
2022-09-26 18:30 ` [PATCH v2] minmax: clamp more efficiently by avoiding extra comparison Kees Cook
2022-09-23 15:10 ` [PATCH] " Andy Shevchenko
2022-09-23 15:11 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy3M5Urqiz8jnIYe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®