mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	Gaosheng Cui <cuigaosheng1@huawei.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] nvmem: core: Fix memleak in nvmem_register()
Date: Sat, 24 Sep 2022 14:52:43 +0200	[thread overview]
Message-ID: <Yy79m+NcW2tmbH5E@kroah.com> (raw)
In-Reply-To: <20220916120402.38753-1-srinivas.kandagatla@linaro.org>

On Fri, Sep 16, 2022 at 01:04:02PM +0100, Srinivas Kandagatla wrote:
> From: Gaosheng Cui <cuigaosheng1@huawei.com>
> 
> dev_set_name will alloc memory for nvmem->dev.kobj.name in
> nvmem_register, when nvmem_validate_keepouts failed, nvmem's
> memory will be freed and return, but nobody will free memory
> for nvmem->dev.kobj.name, there will be memleak, so moving
> nvmem_validate_keepouts() after device_register() and let
> the device core deal with cleaning name in error cases.
> 
> Fixes: de0534df9347 ("nvmem: core: fix error handling while validating keepout regions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Hi Greg,
> 
> Here is a fix in nvmem core which can possibly go in next rc.
> Could you please pick this up.

I missed this for 6.0-final, but as it's only on a not-ever-hit error
path, it can wait for 6.1-rc1.

thanks,

greg k-h

      reply	other threads:[~2022-09-24 12:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 12:04 Srinivas Kandagatla
2022-09-24 12:52 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yy79m+NcW2tmbH5E@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cuigaosheng1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®