From: Johan Hovold <johan@kernel.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH v3] USB: serial: ftdi_sio: Convert to use dev_groups
Date: Tue, 13 Sep 2022 14:48:47 +0200 [thread overview]
Message-ID: <YyB8L5+R2s7Np/DP@hovoldconsulting.com> (raw)
In-Reply-To: <20220905100101.343861-1-jiasheng@iscas.ac.cn>
On Mon, Sep 05, 2022 at 06:01:01PM +0800, Jiasheng Jiang wrote:
> On Fri, Sep 02, 2022 at 10:52:52PM +0800, Greg KH wrote:
> >>> And again, have you tested this change?
> >>
> >> Every time I change the code, I recomplie it and check whether there are
> >> errors.
> >> Are there any other tests I need to do?
> >
> > Yes, boot with the device and make sure that the sysfs files are still
> > there. You do have access to one of these devices, right? They are
> > very very common.
>
> Sorry, I still have no idea how to boot with the device.
You need to buy an FTDI device and plug it into a machine with your
patch applied to the running and make sure that you did not break
anything.
> But if there is any wrong with the patch, you can tell me and I will continue
> to revise it.
It is your job to test your patches.
Johan
next prev parent reply other threads:[~2022-09-13 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 10:01 Jiasheng Jiang
2022-09-13 12:48 ` Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-02 14:33 Jiasheng Jiang
2022-09-02 14:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyB8L5+R2s7Np/DP@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®