From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raul E Rangel <rrangel@chromium.org>
Cc: linux-acpi@vger.kernel.org, linux-input@vger.kernel.org,
jingle.wu@emc.com.tw, mario.limonciello@amd.com,
timvp@google.com, linus.walleij@linaro.org, hdegoede@redhat.com,
rafael@kernel.org, Asmaa Mnebhi <asmaa@nvidia.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
"David S. Miller" <davem@davemloft.net>,
David Thompson <davthompson@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Len Brown <lenb@kernel.org>,
Lu Wei <luwei32@huawei.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 05/13] gpiolib: acpi: Add wake_capable parameter to acpi_dev_gpio_irq_get_by
Date: Tue, 13 Sep 2022 20:10:56 +0300 [thread overview]
Message-ID: <YyC5oEH6NKCMTzzt@smile.fi.intel.com> (raw)
In-Reply-To: <20220912160931.v2.5.I4ff95ba7e884a486d7814ee888bf864be2ebdef4@changeid>
On Mon, Sep 12, 2022 at 04:13:09PM -0600, Raul E Rangel wrote:
> The ACPI spec defines the SharedAndWake and ExclusiveAndWake share type
> keywords. This is an indication that the GPIO IRQ can also be used as a
> wake source. This change exposes the wake_capable bit so drivers can
> correctly enable wake functionality instead of making an assumption.
...
> - ret = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(dev), "irq-gpios", 0);
> + ret = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(dev), "irq-gpios", 0,
> + NULL);
> if (ret < 0)
> return ret;
Looking at these changes, can't we first introduce
int acpi_dev_gpio_irq_get_by_name(struct acpi_device *adev, const char *name);
convert users, and then add wake stuff to the basic function.
In such case you will make less invasive main part of the idea.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-13 18:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 22:13 [PATCH v2 00/13] acpi: i2c: Use SharedAndWake and ExclusiveAndWake to enable wake irq Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 01/13] HID: i2c-hid: Use PM subsystem to manage " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 02/13] Input: elan_i2c - " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 03/13] Input: elants_i2c " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 04/13] Input: raydium_ts_i2c " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 05/13] gpiolib: acpi: Add wake_capable parameter to acpi_dev_gpio_irq_get_by Raul E Rangel
2022-09-13 17:10 ` Andy Shevchenko [this message]
2022-09-14 5:55 ` Mika Westerberg
2022-09-14 15:21 ` Raul Rangel
2022-09-12 22:13 ` [PATCH v2 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags Raul E Rangel
2022-09-13 17:21 ` Andy Shevchenko
2022-09-14 20:49 ` Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq Raul E Rangel
2022-09-13 7:28 ` Wolfram Sang
2022-09-13 15:51 ` Raul Rangel
2022-09-13 17:26 ` Andy Shevchenko
2022-09-13 18:07 ` Raul Rangel
2022-09-13 18:33 ` Andy Shevchenko
2022-09-13 18:56 ` Raul Rangel
2022-09-14 9:42 ` Andy Shevchenko
2022-09-14 18:33 ` Raul Rangel
2022-09-14 5:54 ` Mika Westerberg
2022-09-14 21:00 ` Raul Rangel
2022-09-12 22:13 ` [PATCH v2 08/13] ACPI: PM: Take wake IRQ into consideration when entering suspend-to-idle Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 09/13] HID: i2c-hid: acpi: Stop setting wakeup_capable Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 10/13] HID: i2c-hid: Don't set wake_capable and wake_irq Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 11/13] Input: elan_i2c - " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 12/13] Input: elants_i2c " Raul E Rangel
2022-09-12 22:13 ` [PATCH v2 13/13] Input: raydium_ts_i2c " Raul E Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyC5oEH6NKCMTzzt@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=asmaa@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=hdegoede@redhat.com \
--cc=jingle.wu@emc.com.tw \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei32@huawei.com \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®