From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B58C54EE9 for ; Tue, 13 Sep 2022 13:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231955AbiIMNG6 (ORCPT ); Tue, 13 Sep 2022 09:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231958AbiIMNGw (ORCPT ); Tue, 13 Sep 2022 09:06:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6D6F2F016 for ; Tue, 13 Sep 2022 06:06:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88A116146C for ; Tue, 13 Sep 2022 13:06:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0212C433D7; Tue, 13 Sep 2022 13:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663074409; bh=xkPrNaeSc3nIqS2ojhUubV3xB0uzGFPKPShPBRWyO5A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i46GvtL2piN6QP7oIPU5kk+hN29TVgNbIIpq1HIsjkgOl/YyuUivUJwHXevLBGXA8 Ri001n/F+XjqxEsU4E+wNfEO6lbCmcgzB7IQdi9Vsr5KCaGFMfdmKIyrQKdYC1i/Cj aGYCOsKB4eNryGbVKkTT+hTckG3foYIQnSgXZwnimyV3fjflgRkJgiEsAuIXb7vNZl Gx17kN5udOkuLiXaYi/FiEUHJWEyQwzmyKsjx3bsuoOltAcjHKTS7J1s6LUk1JW2uJ yIIknFicSETojfeaWAaxR1kMZ6aT26Ox+bWUpetufWyqcPQyTMJwID5rtQ0iH86hFm KVgbr/C5QxR7w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oY5cn-0003kc-D4; Tue, 13 Sep 2022 15:06:49 +0200 Date: Tue, 13 Sep 2022 15:06:49 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alex Elder , greybus-dev@lists.linaro.org, stable Subject: Re: [PATCH] staging: greybus: audio_helper: remove unused and wrong debugfs usage Message-ID: References: <20220902143715.320500-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220902143715.320500-1-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2022 at 04:37:15PM +0200, Greg Kroah-Hartman wrote: > In the greybus audio_helper code, the debugfs file for the dapm has the > potential to be removed and memory will be leaked. There is also the > very real potential for this code to remove ALL debugfs entries from the > system, and it seems like this is what will really happen if this code > ever runs. This all is very wrong as the greybus audio driver did not > create this debugfs file, the sound core did and controls the lifespan > of it. Yeah, this looks very broken indeed. > So remove all of the debugfs logic from the audio_helper code as there's > no way it could be correct. If this really is needed, it can come back > with a fixup for the incorrect usage of the debugfs_lookup() call which > is what caused this to be noticed at all. > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: greybus-dev@lists.linaro.org > Cc: linux-staging@lists.linux.dev > Cc: stable > Signed-off-by: Greg Kroah-Hartman I know this has already been applied, but still: Acked-by: Johan Hovold