From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: brgl@bgdev.pl, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/3] gpio: 104-idio-16: Utilize the idio-16 GPIO library
Date: Tue, 13 Sep 2022 19:19:03 +0300 [thread overview]
Message-ID: <YyCtdw14JijxsEQ4@smile.fi.intel.com> (raw)
In-Reply-To: <6f8b7d379a83e1509ec790bbaf0a9e15fdf26180.1662927941.git.william.gray@linaro.org>
On Sun, Sep 11, 2022 at 04:34:39PM -0400, William Breathitt Gray wrote:
> The ACCES 104-IDIO-16 device is part of the ACCES IDIO-16 family, so the
> idio-16 GPIO library module is selected and utilized to consolidate
> code.
> + /* Reading output signals is not supported */
> + if (offset < IDIO_16_NOUT)
> return -EINVAL;
I see it's in the original code, but isn't it possible to cache and return
cached value in such cases?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-13 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 20:34 [PATCH 0/3] Introduce the ACCES IDIO-16 GPIO library module William Breathitt Gray
2022-09-11 20:34 ` [PATCH 1/3] gpio: idio-16: " William Breathitt Gray
2022-09-13 16:16 ` Andy Shevchenko
2022-09-15 15:46 ` William Breathitt Gray
2022-09-17 8:59 ` andy.shevchenko
2022-09-11 20:34 ` [PATCH 2/3] gpio: 104-idio-16: Utilize the idio-16 GPIO library William Breathitt Gray
2022-09-13 16:19 ` Andy Shevchenko [this message]
2022-09-13 16:25 ` William Breathitt Gray
2022-09-11 20:34 ` [PATCH 3/3] gpio: pci-idio-16: " William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyCtdw14JijxsEQ4@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®