From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF1FC54EE9 for ; Tue, 13 Sep 2022 23:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbiIMXTz (ORCPT ); Tue, 13 Sep 2022 19:19:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiIMXTv (ORCPT ); Tue, 13 Sep 2022 19:19:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A54EB1705F; Tue, 13 Sep 2022 16:19:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4BD0AB810DB; Tue, 13 Sep 2022 23:19:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D78CC433D6; Tue, 13 Sep 2022 23:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663111188; bh=b1pLnmMuioHkgk4pVnIfvX2/f7TD1waJQ9v/QDIjOjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TkUT19HGca46QnU2aOU1Zp5C2QLtJmMsxr83BGu9yOV1VKUgBB0pRf378XAqds40a pPGO5iXzOjHPOQtwuVEYXslUcRYN/gtVivAK3YIDBN5JTYSNaqS+6c90EtKLe+uzcr v/vykjRE+P7UreElkm/j0EUexMdpn7aBKsYNGP//oL905bxSiwMxpoML5YdLAT0uuX yBSBLQk755/KaPw9VoERzsgvUX+ILiDBM+Aam+gneYHRJgajKkfvZ92bEQ03cAj496 nWAvrlEe+X62dVCPi7n+aOuY3HBI41avAiNW5QdXi7YhacW2An45kwzdx0Nzv9b1c6 /wPjo8IkDG0rA== Date: Tue, 13 Sep 2022 16:19:45 -0700 From: Nathan Chancellor To: Nathan Huckleberry Cc: Dan Carpenter , llvm@lists.linux.dev, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Nick Desaulniers , Tom Rix , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm: Fix return type of mdp4_lvds_connector_mode_valid Message-ID: References: <20220913205551.155128-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913205551.155128-1-nhuck@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 01:55:48PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode *mode); > > The mismatched return type breaks forward edge kCFI since the underlying > function definition does not match the function hook definition. > > The return type of mdp4_lvds_connector_mode_valid should be changed from > int to enum drm_mode_status. > > Reported-by: Dan Carpenter > Link: https://github.com/ClangBuiltLinux/linux/issues/1703 > Cc: llvm@lists.linux.dev > Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor > --- > drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c > index 7288041dd86a..7444b75c4215 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c > @@ -56,8 +56,9 @@ static int mdp4_lvds_connector_get_modes(struct drm_connector *connector) > return ret; > } > > -static int mdp4_lvds_connector_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > +static enum drm_mode_status > +mdp4_lvds_connector_mode_valid(struct drm_connector *connector, > + struct drm_display_mode *mode) > { > struct mdp4_lvds_connector *mdp4_lvds_connector = > to_mdp4_lvds_connector(connector); > -- > 2.37.2.789.g6183377224-goog >