From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371D6C54EE9 for ; Mon, 19 Sep 2022 09:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229872AbiISJJ2 (ORCPT ); Mon, 19 Sep 2022 05:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbiISJJX (ORCPT ); Mon, 19 Sep 2022 05:09:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD29CE0E8 for ; Mon, 19 Sep 2022 02:09:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 496DE61882 for ; Mon, 19 Sep 2022 09:09:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A05CC433D6; Mon, 19 Sep 2022 09:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663578561; bh=WHDOUGDBEFXAWWV1HrED2NCv+2En8pl2kk+OmNIMVvs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N/pdsEoT/57mv94SqnWmIEqEDBRbN3pCVWL5UKZu8AuPLskbcc6rit2GCQhFNAGnn aX6eCVSqQJ+ESZZQwbBcyv3KeVU6+FTchmJce+szucJersLH5ctIscwn5iBq3YWI6G D+Iy38K8TlSqjN3UXp2SrhXKXev+EIvxknMOyvb0= Date: Mon, 19 Sep 2022 11:09:48 +0200 From: Greg Kroah-Hartman To: Kang Minchul Cc: Hans de Goede , Fabio Aiuto , Kees Cook , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment Message-ID: References: <20220917181130.3237159-1-tegongkang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220917181130.3237159-1-tegongkang@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote: > This patch removes the following warning generated by checkpatch.pl > > WARNING: Block comments use * on subsequent lines > #206: FILE: rtw_recv.c:206: > +/* > +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) > > WARNING: Block comments use * on subsequent lines > #216: FILE: rtw_recv.c:216: > +/* > +caller : defrag ; recvframe_chk_defrag in recv_thread (passive) > > Signed-off-by: Kang Minchul > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c > index d8d394b67eeb..ad6fb6c3d1f0 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c > @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q > } > > /* > -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) > -{ > - return rtw_free_recvframe(precvframe, queue); > -} > -*/ > + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue) > + * { > + * return rtw_free_recvframe(precvframe, queue); > + * } > + */ I agree with Dan, just remove these unused functions please. thanks, greg k-h