From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F33BECAAD3 for ; Mon, 19 Sep 2022 13:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbiISNrY (ORCPT ); Mon, 19 Sep 2022 09:47:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230511AbiISNrM (ORCPT ); Mon, 19 Sep 2022 09:47:12 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E34D31207; Mon, 19 Sep 2022 06:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663595210; x=1695131210; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=jBbg9Ly3UJMnDmMmkjxG2CXACR0TAhGMOhRzvVmCwvs=; b=Av6zqIxHRTP/UYais3cmU5tsxf6ncaNJc60BELuZkx36r/ZQYyNRmZNQ xfZqT1j/03vx+0aBTXM4BsdeIrDkt4ntyHCu87nVSUeN56U+7O6AfC6Hk ZVIBbFsq6V/MP7bRhzBVkC4O/aYnoumyaqpCo2TUPyWxGtN8BO3P+B3hN Olzk/vwd1l+kNnNaQBb4K4ysrtfr5tKMCo3TPuTO4QGDOGK15eXeT4Eht LO5mP9eYOGQd8CRFLiwnhtkswH2EEA+z1oVzMAjyzxoZVj/fbmSv1wJrL PZaDIRdK6pIP2IugCn/eroVOgs/XDpC0fKHTpHytt4HnipTML6/boo8pJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="296996552" X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="296996552" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 06:46:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="651684842" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 19 Sep 2022 06:46:48 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oaH6k-004ZdO-2Q; Mon, 19 Sep 2022 16:46:46 +0300 Date: Mon, 19 Sep 2022 16:46:46 +0300 From: Andy Shevchenko To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Lennert Buytenhek , Greg Kroah-Hartman , Jiri Slaby , linux-serial , LKML Subject: Re: I/O page faults from 8250_mid PCIe UART after TIOCVHANGUP Message-ID: References: <7fd034a9-c1e1-2dca-693b-129c9d2649@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7fd034a9-c1e1-2dca-693b-129c9d2649@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2022 at 07:27:45PM +0300, Ilpo Järvinen wrote: > On Wed, 14 Sep 2022, Andy Shevchenko wrote: > > On Wed, Sep 14, 2022 at 02:10:44PM +0300, Lennert Buytenhek wrote: > > > On Wed, Sep 14, 2022 at 01:09:40PM +0300, Andy Shevchenko wrote: ... > - /* > - * The above check will only give an accurate result the first time > - * the port is opened so this value needs to be preserved. > - */ Side note: I haven't got why you removed this comment (it may be some staled info, but shouldn't be done in the separate change then?). -- With Best Regards, Andy Shevchenko