From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, kishon@ti.com,
vkoul@kernel.org, hverkuil@xs4all.nl, jacopo@jmondi.org,
kieran.bingham+renesas@ideasonboard.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
kernel@pengutronix.de
Subject: Re: [PATCH v2 4/4] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver
Date: Mon, 19 Sep 2022 19:54:36 +0000 [thread overview]
Message-ID: <YyjI/JOcryD8yKzT@paasikivi.fi.intel.com> (raw)
In-Reply-To: <Yyio06jhK13BiNiP@pendragon.ideasonboard.com>
On Mon, Sep 19, 2022 at 08:37:23PM +0300, Laurent Pinchart wrote:
> > > > + ctrl = v4l2_ctrl_new_int_menu(&tc358746->ctrl_hdl, NULL,
> > > > + V4L2_CID_LINK_FREQ, 0, 0,
> > >
> > > Shouldn't the max argument be set to the number of items minus 1 ?
> >
> > Right now I would keep it that way since the driver only supports one
> > link-frequencies setting. So the ctrl don't let the userspace assume
> > that there are more than one link-frequency.
>
> Good point. Can you add a short comment above the call to explain this ?
Wouldn't it be just easier to do what Laurent suggested originally? The end
result is the same, isn't it, and no comment needed?
>
> > > > + link_frequencies);
> > > > + if (ctrl)
> > > > + ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
Now that this is a bridge, this value presumably doesn't need to change.
There will just be more blanking if the source sub-device pixel rate is
slower, right?
--
Sakari Ailus
next prev parent reply other threads:[~2022-09-19 19:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:45 [PATCH v2 0/4] Add support for Toshiba TC358746 Marco Felsch
2022-09-16 13:45 ` [PATCH v2 1/4] phy: dphy: refactor get_default_config Marco Felsch
2022-09-16 13:45 ` [PATCH v2 2/4] phy: dphy: add support to calculate the timing based on hs_clk_rate Marco Felsch
2022-09-16 13:45 ` [PATCH v2 3/4] media: dt-bindings: add bindings for Toshiba TC358746 Marco Felsch
2022-09-17 23:06 ` Laurent Pinchart
2022-09-19 10:08 ` Marco Felsch
2022-09-19 10:23 ` Sakari Ailus
2022-09-19 10:55 ` Laurent Pinchart
2022-09-20 15:26 ` Marco Felsch
2022-09-20 17:32 ` Laurent Pinchart
2022-09-21 7:24 ` Krzysztof Kozlowski
2022-09-21 8:35 ` Marco Felsch
2022-09-21 8:59 ` Krzysztof Kozlowski
2022-09-22 11:01 ` Marco Felsch
2022-09-22 12:09 ` Krzysztof Kozlowski
2022-09-16 13:45 ` [PATCH v2 4/4] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver Marco Felsch
2022-09-17 1:28 ` kernel test robot
2022-09-19 12:39 ` Sakari Ailus
2022-09-19 12:49 ` Laurent Pinchart
2022-09-19 13:03 ` Sakari Ailus
2022-09-20 11:35 ` Marco Felsch
2022-09-19 12:46 ` Laurent Pinchart
2022-09-19 17:11 ` Marco Felsch
2022-09-19 17:37 ` Laurent Pinchart
2022-09-19 19:54 ` Sakari Ailus [this message]
2022-09-20 8:39 ` Marco Felsch
2022-09-20 8:53 ` Sakari Ailus
2022-09-20 10:48 ` Marco Felsch
2022-09-20 11:14 ` Laurent Pinchart
2022-09-20 11:53 ` Marco Felsch
2022-09-20 12:02 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyjI/JOcryD8yKzT@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®