From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hidenori Kobayashi <hidenorik@chromium.org>
Cc: Dongchun Zhu <dongchun.zhu@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ov8856: Add runtime PM callbacks
Date: Tue, 20 Sep 2022 11:37:06 +0300 [thread overview]
Message-ID: <Yyl7spRDgJ+R39Pj@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20220920020002.710533-1-hidenorik@chromium.org>
Hi Hidenori,
On Tue, Sep 20, 2022 at 11:00:01AM +0900, Hidenori Kobayashi wrote:
> There were no runtime PM callbacks registered, leaving regulators being
> enabled while the device is suspended on DT systems. Calling existing
> power controlling functions from callbacks properly turn them off/on.
>
> Signed-off-by: Hidenori Kobayashi <hidenorik@chromium.org>
> ---
> drivers/media/i2c/ov8856.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
> index a9728afc81d4..3f57bc30b78b 100644
> --- a/drivers/media/i2c/ov8856.c
> +++ b/drivers/media/i2c/ov8856.c
> @@ -2200,6 +2200,26 @@ static int __maybe_unused ov8856_resume(struct device *dev)
> return 0;
> }
>
> +static int __maybe_unused ov8856_runtime_suspend(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov8856 *ov8856 = to_ov8856(sd);
> +
> + __ov8856_power_off(ov8856);
Could you refactor this a bit, changing the __ov8856_power_off() argument
to struct dev *?
> +
> + return 0;
> +}
> +
> +static int __maybe_unused ov8856_runtime_resume(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov8856 *ov8856 = to_ov8856(sd);
> +
> + return __ov8856_power_on(ov8856);
> +}
> +
> static int ov8856_set_format(struct v4l2_subdev *sd,
> struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_format *fmt)
> @@ -2540,6 +2560,7 @@ static int ov8856_probe(struct i2c_client *client)
>
> static const struct dev_pm_ops ov8856_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(ov8856_suspend, ov8856_resume)
> + SET_RUNTIME_PM_OPS(ov8856_runtime_suspend, ov8856_runtime_resume, NULL)
> };
>
> #ifdef CONFIG_ACPI
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2022-09-20 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 2:00 Hidenori Kobayashi
2022-09-20 8:37 ` Sakari Ailus [this message]
2022-09-21 1:32 ` Hidenori Kobayashi
2022-09-21 7:44 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyl7spRDgJ+R39Pj@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=dongchun.zhu@mediatek.com \
--cc=hidenorik@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®