From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: paolo.valente@linaro.org, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq
Date: Tue, 20 Sep 2022 00:25:53 -0700 [thread overview]
Message-ID: <YylrAbQ75wCAj5va@infradead.org> (raw)
In-Reply-To: <20220919070916.2738443-4-yukuai1@huaweicloud.com>
Matching names is always is a bad idea.
Just ad a flags field to elevator_mq_ops, add a DISABLE_WBT flag
to it, and check for that and everything should become much, much
simpler.
next prev parent reply other threads:[~2022-09-20 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 7:09 [PATCH v2 0/3] blk-wbt: simple improvment to enable wbt correctly Yu Kuai
2022-09-19 7:09 ` [PATCH v2 1/3] wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled Yu Kuai
2022-09-19 7:09 ` [PATCH v2 2/3] block: add a helper to check elevator name Yu Kuai
2022-09-19 7:09 ` [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq Yu Kuai
2022-09-20 7:25 ` Christoph Hellwig [this message]
2022-09-20 7:48 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YylrAbQ75wCAj5va@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®