From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16950C6FA82 for ; Wed, 21 Sep 2022 03:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbiIUDyX (ORCPT ); Tue, 20 Sep 2022 23:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231194AbiIUDyU (ORCPT ); Tue, 20 Sep 2022 23:54:20 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D5151CFDC for ; Tue, 20 Sep 2022 20:54:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E60A021B4B; Wed, 21 Sep 2022 03:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663732457; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nIbc/7y4eQaQeiEASLP8Mx3nQNV8bI27qmhnLRpUYVw=; b=gIN/sXkZBGKBnUmz5gPol/PonAMZXIi67UGjRYobz+DTg79GTHYSAJHbJ/9GKaO2iPYHwp hzoq1u+X7EPc0zOQ5lrfYAZG9yHE69RRvXqT5HlHJiaDotFOR6YNzcNutR8O0aMB7zHDvC wxKVe/6yyMEOgxuREw1lm/5qE+PvyaQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663732457; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nIbc/7y4eQaQeiEASLP8Mx3nQNV8bI27qmhnLRpUYVw=; b=JtK9ronxdDqst8rlqP4WmaHadwdA9EVUyUj8Iuhs8RVwrOW2TInv531qOCeD9y4HlLCdqM UQT/TCIjJdcrE1Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 538B91332F; Wed, 21 Sep 2022 03:54:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dfKtEemKKmMDPQAAMHmgww (envelope-from ); Wed, 21 Sep 2022 03:54:17 +0000 Date: Wed, 21 Sep 2022 05:54:15 +0200 From: Oscar Salvador To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Joao Martins , Matthew Wilcox , Michal Hocko , Peter Xu , Miaohe Lin , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH v2] hugetlb: freeze allocated pages before creating hugetlb pages Message-ID: References: <20220916214638.155744-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 10:10:29AM -0700, Mike Kravetz wrote: > Hi Oscar, thanks for taking a look. > > I think you may have missed something in the above comment. For gigantic > pages, we only freeze pages if NOT demote. In the demote case, pages are > already frozen. Yeah. It got me confused that the link you posted (https://lore.kernel.org/linux-mm/20210622021423.154662-3-mike.kravetz@oracle.com/) seemed like an earlier version of what it got into upstream, and in there there was "demotion" handling. Having checked the tree it all looks sound. I will wait for v3. Thanks Mike! -- Oscar Salvador SUSE Labs