From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6A53C6FA8B for ; Thu, 22 Sep 2022 08:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbiIVIcv (ORCPT ); Thu, 22 Sep 2022 04:32:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiIVIcr (ORCPT ); Thu, 22 Sep 2022 04:32:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0CB548EA8; Thu, 22 Sep 2022 01:32:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5199560AD7; Thu, 22 Sep 2022 08:32:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EA76C43470; Thu, 22 Sep 2022 08:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663835562; bh=SWY50SPMYrQ9rKOjBPbGXTzfecN4RKVk8BYGba7UI4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k6+JwbVbL/3GxVfZwrn0D8UhOmQink/gUlUVmQbHptKUsQe0LSrFbdwR+1W7L/7fQ UVFjfExu/p1DbcMESH4UhRIReudLS1ibtSVkt5cjNx9yYaDbEtkgU3hp7N/ENviBq/ qb73w/gTBlscXjSiOeEp7yClHUCgBkjA+OlghPLs= Date: Thu, 22 Sep 2022 10:32:39 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: Bagas Sanjaya , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, stable@vger.kernel.org, lwn@lwn.net, jslaby@suse.cz, Jason Wang Subject: Re: Linux 4.14.294 Message-ID: References: <1663669061118192@kroah.com> <1663669061138255@kroah.com> <445878e0-d8c9-558f-73b7-8d39fa1a5cde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2022 at 01:26:59AM -0700, Joe Perches wrote: > On Thu, 2022-09-22 at 08:53 +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 22, 2022 at 11:02:21AM +0700, Bagas Sanjaya wrote: > > > On 9/22/22 01:03, Joe Perches wrote: > > > > On Tue, 2022-09-20 at 12:17 +0200, Greg Kroah-Hartman wrote: > > > > [] > > > > > diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h > > > > [] > > > > > @@ -118,7 +118,7 @@ struct report_list { > > > > > * @multi_packet_cnt: Count of fragmented packet count > > > > > * > > > > > * This structure is used to store completion flags and per client data like > > > > > - * like report description, number of HID devices etc. > > > > > + * report description, number of HID devices etc. > > > > > */ > > > > > struct ishtp_cl_data { > > > > > /* completion flags */ > > > > > > > > Needless backporting of typo fixes reduces confidence in the > > > > backport process. > > > > > > > > > > The upstream commit 94553f8a218540 ("HID: ishtp-hid-clientHID: ishtp-hid-client: > > > Fix comment typo") didn't Cc: stable, but got AUTOSELed [1]. > > > > > > I think we should only AUTOSEL patches that have explicit Cc: stable. > > > > That's not how AUTOSEL works or why it is there at all, sorry. > > Perhaps not, but why is AUTOSEL choosing this and why is > this being applied without apparent human review? We always appreciate more review, and welcome it. Sometimes things slip by us as well, like it did for this one. The changelog makes it look like a real fix that is needed. thanks, greg k-h