From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 946C6C6FA90 for ; Thu, 22 Sep 2022 08:46:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230454AbiIVIqZ (ORCPT ); Thu, 22 Sep 2022 04:46:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230457AbiIVIp4 (ORCPT ); Thu, 22 Sep 2022 04:45:56 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36708D01CB for ; Thu, 22 Sep 2022 01:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GJSFq9n4IhTHE9LgY9araioWWsK4zmhxNFi739AGsPo=; b=XwJrVigSu5bOF7oxRDqBIlMMQI 3Jxcxfu2wcdnszoe8TrJL/vCRq1YXzL7ysaUqRq/3jN/40P99Ie63b5G+EfTALeIFcwGLht8JPA9c qaZ26ZfqdPH0gw8vh4KopCuuzFxuow0TXO/TcJe/VoIE+x7Duq89RSooLj81oV/uzemMP4C+xRwWU reuDRTwCJmqK4Pe9TQrOfUMcSP8/NUpY38WzTe/z52C/Xd1m960aUxEeJpDYiDJxXgDBM+kDzd8ru YbP4OkpDQmpvR1oQzI08sUJirU04ItKdT/5wc1neJPuf9pbRSKb4+k7/LGJgrdvjn1JqXGUAym7nC jdJhC20g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1obHpt-00Ev25-BR; Thu, 22 Sep 2022 08:45:33 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BD357300169; Thu, 22 Sep 2022 10:45:31 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6EFEC2B662EF7; Thu, 22 Sep 2022 10:45:31 +0200 (CEST) Date: Thu, 22 Sep 2022 10:45:31 +0200 From: Peter Zijlstra To: Waiman Long Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Tejun Heo , Zefan Li , Johannes Weiner , Will Deacon , linux-kernel@vger.kernel.org, Linus Torvalds , Lai Jiangshan Subject: Re: [PATCH v9 0/7] sched: Persistent user requested affinity Message-ID: References: <20220916183217.1172225-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916183217.1172225-1-longman@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 02:32:10PM -0400, Waiman Long wrote: > Waiman Long (7): > sched: Add __releases annotations to affine_move_task() > sched: Use user_cpus_ptr for saving user provided cpumask in > sched_setaffinity() > sched: Enforce user requested affinity > sched: Introduce affinity_context structure > sched: Handle set_cpus_allowed_ptr() & sched_setaffinity() race > sched: Fix sched_setaffinity() and fork/clone() race > sched: Always clear user_cpus_ptr in do_set_cpus_allowed() I still think this is ordered all wrong. Esp. with that affinity context doing the right thing isn't onerous at all. So please, re-order this and fold all fixes back in so that it becomes a sane series. Basically patches 5 and 6 shouldn't exist, they fix issues created by the earlier patches.