From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB02EC4332F for ; Fri, 7 Oct 2022 09:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbiJGJXw (ORCPT ); Fri, 7 Oct 2022 05:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiJGJXa (ORCPT ); Fri, 7 Oct 2022 05:23:30 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB405DED39; Fri, 7 Oct 2022 02:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665134609; x=1696670609; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wF0L8JKp6G/b7hzsjOLcyP2vJYun72D+/xZPLLlg6gw=; b=QKyNHLVBJHJk0tNpQzm5cYUMZDsApUsOBaRn8fVAHw7olrgQ30QgEqRy 67+sSD0odeGbYa6obVHzQGecmqWkQ6pp+JykrzC2/xrUgo69JZzyi0AuF YelQsSSycYkf2nPuGqPWs9ouLSCtAsa55/IqmFtzVpHBLXBeKhfCH1v2x VfGxeV2B7e5aM40r0XbG0Jn3ZP5OVmQ5Crcd6fbrwN2gq0FB3eIXttoJJ nIL8nLnXb3Xg5q3KutZ0g9zGcvNtCs84hojZ8XfM+Y4CySwb3ruF468cL eGnGRu2dGaCVKBQazXEYKmK1s8B37zkL7+jK0avutDKYDwkAiqn6hMnx6 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="301292357" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="301292357" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 02:23:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10492"; a="602805095" X-IronPort-AV: E=Sophos;i="5.95,166,1661842800"; d="scan'208";a="602805095" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 07 Oct 2022 02:23:26 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ogjZk-003Y2X-0a; Fri, 07 Oct 2022 12:23:24 +0300 Date: Fri, 7 Oct 2022 12:23:23 +0300 From: Andy Shevchenko To: Joe Perches Cc: Matti Vaittinen , Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Jagath Jog J , Nikita Yushchenko , Cosmin Tanislav , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 4/5] iio: accel: Support Kionix/ROHM KX022A accelerometer Message-ID: References: <88e24b01da9f44ebf5fcd8344ded0b75ff742fbf.1665066397.git.mazziesaccount@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 07, 2022 at 12:04:20AM -0700, Joe Perches wrote: > On Thu, 2022-10-06 at 21:32 +0300, Andy Shevchenko wrote: > > On Thu, Oct 06, 2022 at 05:38:14PM +0300, Matti Vaittinen wrote: > > > KX022A is a 3-axis accelerometer from ROHM/Kionix. The senosr features > > > include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ, > > > tap/motion detection, wake-up & back-to-sleep events, four acceleration > > > ranges (2, 4, 8 and 16g) and probably some other cool features. > [] > > > +/* > > > + * Threshold for deciding our HW fifo is unrecoverably corrupt and should be > > > + * cleared > > > > Multi-line comments have to follow English grammar and punctuation, > > i.e. trailing period. > > I disagree. I think that would be a silly rule to enforce. First, you have to read that submission and find at least inconsistency between styles used for different multi-line comment blocks. -- With Best Regards, Andy Shevchenko