From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8CF1C433FE for ; Thu, 6 Oct 2022 06:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbiJFGcp (ORCPT ); Thu, 6 Oct 2022 02:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbiJFGcn (ORCPT ); Thu, 6 Oct 2022 02:32:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2E3245F4E for ; Wed, 5 Oct 2022 23:32:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 80794B81FB0 for ; Thu, 6 Oct 2022 06:32:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A966FC433D6; Thu, 6 Oct 2022 06:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665037960; bh=QPMJFooJTr6EOzcnJDVXxYbqDFz5t2GLsNU9+P46b7g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=anV9MWKFIAUwGYCF11N8RcB4wFaZSs5lx4htFdPmjT5P1sv218TcZlS1zMsxNBy9e wPBjfW4LKNGlKddEnGuAj8dCo53F4Yy3i7CEwkSxGZPzUMaVIILkiPClo9vpE+J25Y aQFP65J65mf5/ffnTQFSjSFMKHYj4ZCmE05EXnEI= Date: Thu, 6 Oct 2022 08:33:19 +0200 From: Greg KH To: Julius Werner Cc: Jack Rosenthal , LKML , chrome-platform@lists.linux.dev, Stephen Boyd , Tzung-Bi Shih , Guenter Roeck Subject: Re: [PATCH v12] firmware: google: Implement cbmem in sysfs driver Message-ID: References: <20221004003811.4075765-1-jrosenth@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 05, 2022 at 04:26:55PM -0700, Julius Werner wrote: > > If the kernel is reporting a value, that value needs to be documented > > somewhere. If the kernel is acting on that value, it needs to know what > > those values are. > > > > In this specific instance it seems that the kernel knows a subset of the > > values, and some random userspace tool knows all of them? Think about > > what you would want to see here if you knew nothing about this at all. > > The kernel doesn't know any of the values. The kernel is just telling > userspace that spaces with these IDs exist and providing an interface > to access them, it's not supposed to know what any of them mean. Ah, ok, that was not obvious to me, sorry. If the kernel is just a pass-through, no objections. thanks, greg k-h