From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336D3C4332F for ; Thu, 6 Oct 2022 06:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbiJFGfw (ORCPT ); Thu, 6 Oct 2022 02:35:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbiJFGfr (ORCPT ); Thu, 6 Oct 2022 02:35:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4648A696CB; Wed, 5 Oct 2022 23:35:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 857E0B81EA0; Thu, 6 Oct 2022 06:35:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00ED8C433C1; Thu, 6 Oct 2022 06:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665038142; bh=Wbu3shF6t8LvrsmEHzefRcotejG/Z5j72dNtKsmroMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O5FX1N4q/5udncTDUfc/4mBdtA31HRFcl3nAaLaG5eTkT3sepCeaG3sO1Wy9Ta44F 2fI6eZf1Q9whdgx2zNPqtAeGgkZ8Omt1Fq87LLfQwwVQpO1s7Vg165rG60F+kOsq67 Om8KcLqf8x6kgR0kIETfR5+SB1DPmYPGiwhcGPn4RRWym+gogHsQKWE6alWRrHKMay phdeQcsmCvMDy31GrzjfrEizgBTOYkRRtU/SIpjGvL7NB2ZeGrNm7qC37DVyIochlH xwNbH5A6hY0dINpMb+ZPkqOE/BDwAd72tKde3cDfZXBfX/DlLumq+M5O8mOSI89Qrb kMmp+VRU2jrYw== Date: Thu, 6 Oct 2022 08:35:34 +0200 From: Lorenzo Pieralisi To: Bjorn Helgaas Cc: Manivannan Sadhasivam , kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org, robh@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] PCI: qcom-ep: Fix disabling global_irq in error path Message-ID: References: <20221005135852.22634-1-manivannan.sadhasivam@linaro.org> <20221005173529.GA2304247@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221005173529.GA2304247@bhelgaas> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 05, 2022 at 12:35:29PM -0500, Bjorn Helgaas wrote: > On Wed, Oct 05, 2022 at 07:28:52PM +0530, Manivannan Sadhasivam wrote: > > After commit 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver > > remove"), the global irq is stored in the "global_irq" member of pcie_ep > > structure. This eliminates the need of local "irq" variable but that > > commit didn't remove the "irq" variable usage completely and it is still > > used for disable_irq() in error path which is wrong since the variable is > > uninitialized. > > > > Fix this by removing the local "irq" variable and using > > "pcie_ep->global_irq" for disable_irq() in error path. > > > > Reported-by: kernel test robot > > Fixes: 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver remove") > > Signed-off-by: Manivannan Sadhasivam > > For today's "next" branch, I dropped 6a534df3da88 and the subsequent > patches. Hopefully Lorenzo can squash this fix into 6a534df3da88. Done - the pci/qcom branch successfully passed kbot's tests as well. Lorenzo