From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F9AC6FA90 for ; Mon, 26 Sep 2022 15:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234933AbiIZPH0 (ORCPT ); Mon, 26 Sep 2022 11:07:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234117AbiIZPFb (ORCPT ); Mon, 26 Sep 2022 11:05:31 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14D4ED70F9; Mon, 26 Sep 2022 06:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nITPYkhiQSASd/MBANOu6ZY1JaJ2D7mfRTlbFizAq1Q=; b=M27OC6mbY14hs43Q+3USZW4mwQ tfYCHnPW0UGV5ubIcF91Ihyzgh6P0XtjDrQuNlKn+1tfvks/bzQr3+/CHLvyJrfgsoUkJ3gG2teHu 2JTPR/RONDBbFlm608/9434IZF0nT35NB55R3z++eDVgf6R+JC1i7qacPeDtx9HPh7bU9O7zp6jUx gk/i+qUbd/lVfEXX3gG2obaRAQoMZNgS3uvvwbJNPfMsPByzZ37xHMv9nXqZ88JAU6sV39eezKF9Z rULZl2hbDuz7wywOd9l5tTLSBl14DraCgoPMplYK9mHQpw7gBOaX43ETvqbROTs9ocRGIo3R8lMki iK8uknYw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocoIp-00G25A-Ni; Mon, 26 Sep 2022 13:37:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 674353001D6; Mon, 26 Sep 2022 15:37:42 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1F6A9205B02A9; Mon, 26 Sep 2022 15:37:42 +0200 (CEST) Date: Mon, 26 Sep 2022 15:37:41 +0200 From: Peter Zijlstra To: Christian Borntraeger Cc: bigeasy@linutronix.de, dietmar.eggemann@arm.com, ebiederm@xmission.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, mgorman@suse.de, mingo@kernel.org, oleg@redhat.com, rjw@rjwysocki.net, rostedt@goodmis.org, tj@kernel.org, vincent.guittot@linaro.org, will@kernel.org, Marc Hartmayer , Amit Shah , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH v3 6/6] freezer,sched: Rewrite core freezer logic Message-ID: References: <20220822114649.055452969@infradead.org> <20220923072104.2013212-1-borntraeger@linux.ibm.com> <56576c3c-fe9b-59cf-95b8-158734320f24@linux.ibm.com> <436fa401-e113-0393-f47a-ed23890364d7@linux.ibm.com> <39dfc425-deff-2469-7bcb-4a0e177b31d1@linux.ibm.com> <66463973-923f-624d-3041-72ce76147b3e@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66463973-923f-624d-3041-72ce76147b3e@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 03:23:10PM +0200, Christian Borntraeger wrote: > Am 26.09.22 um 14:55 schrieb Peter Zijlstra: > > > Could you please test with something like the below on? I can boot that > > with KVM, but obviously I didn't suffer any weirdness to begin with :/ > > > > --- > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 4e6a6417211f..ef9ccfc3a8c0 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -4051,6 +4051,8 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) > > unsigned long flags; > > int cpu, success = 0; > > + WARN_ON_ONCE(state & TASK_FREEZABLE); > > + > > preempt_disable(); > > if (p == current) { > > /* > > Does not seem to trigger. Moo -- quite the puzzle this :/ I'll go stare at it more then.