From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 357EAC07E9D for ; Mon, 26 Sep 2022 16:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229976AbiIZQuy (ORCPT ); Mon, 26 Sep 2022 12:50:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbiIZQth (ORCPT ); Mon, 26 Sep 2022 12:49:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9CA170E68 for ; Mon, 26 Sep 2022 08:44:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C5AB60EB9 for ; Mon, 26 Sep 2022 15:44:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87AE2C433C1; Mon, 26 Sep 2022 15:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664207045; bh=KqwfvvLz7Jsc+ZWwezsHsbqwLK7s9ZRi+MT15QtrN2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HJ1XZaMmr/6BrIK1ccRTKxqsFtsqI1jydwSPei9UcIjJs/jQlQNEy/ZJtGa7e7h7X jvHxsq5xIWfCGddi97a5dXcDX6H7l67UXtv1TOwtdKsZrdgEWWnJGBUd3zyAUp/tMo IkORYNDjRy8FL49wcFzxiOM8WdZFfRDOQ/IzESu7Jl4d4rk6bPQDFE9I/HY70u5axv s0iwThkVkB+uLTWjZgLxUmBjXzBv0PRwGyjnDcPmhKbjB61zW0WhKGFYg8SlQcqi0Y +YbYrgihiySc2S0HEFz0zqO/T+djkTjC7BK2FVPN+DajllluyHlLXtqE82jai4oyBX Ea8maN0IdWq5w== Date: Mon, 26 Sep 2022 08:44:02 -0700 From: Nathan Chancellor To: Naresh Kamboju Cc: open list , Linux ARM , Arnd Bergmann , "Russell King (Oracle)" , Masami Hiramatsu , regressions@lists.linux.dev, lkft-triage@lists.linaro.org Subject: Re: arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede .save or .vsave directives Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naresh, On Mon, Sep 26, 2022 at 06:57:00PM +0530, Naresh Kamboju wrote: > Following build warnings / errors noticed on arm with clang-13 / 14 > on Linux next-20220923. > > Reported-by: Linux Kernel Functional Testing > > Regressions found on arm: > > - build-clang-13-bcm2835_defconfig > - build-clang-nightly-imx_v6_v7_defconfig > - build-clang-nightly-orion5x_defconfig > - build-clang-13-keystone_defconfig > - build-clang-13-omap2plus_defconfig > - build-clang-14-imx_v6_v7_defconfig > - build-clang-nightly-omap2plus_defconfig > - build-clang-nightly-multi_v5_defconfig > - build-clang-nightly-bcm2835_defconfig > - build-clang-13-imx_v6_v7_defconfig > - build-clang-13-imx_v4_v5_defconfig > - build-clang-14-imx_v4_v5_defconfig > - build-clang-13-orion5x_defconfig > - build-clang-14-multi_v5_defconfig-65236a87 > - build-clang-14-lkftconfig > - build-clang-nightly-imx_v4_v5_defconfig > - build-clang-13-multi_v5_defconfig > - build-clang-13-lkftconfig > - build-clang-nightly-keystone_defconfig > - build-clang-14-multi_v5_defconfig > - build-clang-14-orion5x_defconfig > - build-clang-14-omap2plus_defconfig > - build-clang-nightly-multi_v5_defconfig-65236a87 > - build-clang-14-bcm2835_defconfig > - build-clang-14-keystone_defconfig > - build-clang-nightly-lkftconfig > > arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede > .save or .vsave directives > "stmdb sp, {sp, lr, pc} \n\t" > ^ > :3:2: note: instantiated into assembly here > .save {sp, lr, pc} > ^ > /builds/linux/arch/arm/probes/kprobes/core.c:412:29: error: .fnstart > must precede .pad directive > "stmdb sp!, {r0 - r11} \n\t" > ^ > :6:2: note: instantiated into assembly here > .pad #52 > ^ > 2 errors generated. > make[5]: *** [/builds/linux/scripts/Makefile.build:250: > arch/arm/probes/kprobes/core.o] Error 1 > > build log: > https://builds.tuxbuild.com/2FAyD1qcTlzjIYE7mjrugjCsxu1/ Thank you for the testing and report! I brought this up on GitHub on Friday as I noticed this as well: https://github.com/ClangBuiltLinux/linux/issues/1718 It sounds like we can avoid this by rewriting __kretprobe_trampoline() in out of line assembly but I have not had a chance to sit down and try it. Cheers, Nathan