From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E5EC6FA93 for ; Mon, 26 Sep 2022 16:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbiIZQ6J (ORCPT ); Mon, 26 Sep 2022 12:58:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230093AbiIZQ5w (ORCPT ); Mon, 26 Sep 2022 12:57:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F49261D67; Mon, 26 Sep 2022 08:53:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE4AAB80AF1; Mon, 26 Sep 2022 15:53:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBF53C433C1; Mon, 26 Sep 2022 15:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664207636; bh=0crWaPXBHQZ29qdGzZd0JYh4qhM+URw3eXnNCAjtI1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gODjHIt2kUVr5VF9QN5sgYvJvod+whH/q8QJHk4T1No91iuU0iYYRG30XmYbR6ULY bO9YNbFYtkgt+aPXEfAL3lDe+q+3AGJbYJ3himCuMf/BbNJ8FTqi1WHAKJEjAwIqvd Bp0JESAfiLYqjPb4MZoZ4nRipGRfeYPtBa88CNpM= Date: Mon, 26 Sep 2022 17:53:53 +0200 From: Greg Kroah-Hartman To: Ard Biesheuvel Cc: Pavel Machek , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Daniel Marth , Kees Cook , Sasha Levin Subject: Re: [PATCH 4.14 06/40] efi: libstub: Disable struct randomization Message-ID: References: <20220926100738.148626940@linuxfoundation.org> <20220926100738.463310701@linuxfoundation.org> <20220926110826.GE8978@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 04:16:02PM +0200, Ard Biesheuvel wrote: > On Mon, 26 Sept 2022 at 13:08, Pavel Machek wrote: > > > > Hi! > > > > > These structs look like the ideal randomization candidates to the > > > randstruct plugin (as they only carry function pointers), but of course, > > > these protocols are contracts between the firmware that exposes them, > > > and the EFI applications (including our stubbed kernel) that invoke > > > them. This means that struct randomization for EFI protocols is not a > > > great idea, and given that the stub shares very little data with the > > > core kernel that is represented as a randomizable struct, we're better > > > off just disabling it completely here. > > > > > Cc: # v4.14+ > > > > AFAICT RANDSTRUCT_CFLAGS is not available in v4.19, so we should not > > take this patch. > > > > Ugh, as it turns out, this macro doesn't exist before v5.19 so it > should not be backported beyond that version at all. > > Greg, can you please drop this patch from all the -stable trees except > v5.19? Thanks, and apologies for creating confusion. Now dropped from the 4.14, 4.19, and 5.4 queues, it is already in the 5.10 release. thanks, greg k-h