From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE4A3C32771 for ; Mon, 26 Sep 2022 18:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbiIZSmh (ORCPT ); Mon, 26 Sep 2022 14:42:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbiIZSlp (ORCPT ); Mon, 26 Sep 2022 14:41:45 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74270F4B for ; Mon, 26 Sep 2022 11:40:46 -0700 (PDT) Received: from zn.tnic (p200300ea9733e74d329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e74d:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6B1511EC059D; Mon, 26 Sep 2022 20:40:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664217640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=UV5G03i0J4ZmYbbzPbEHCNnZgOVKlnCjwA4cScXyt1s=; b=CBzVjLPvs9Eewc7z3KLHoPORsEoDeJAqHqS/Kz75vg3KYyXNHMSTOMzaMeXc8RciECdqhh m7Ew6CupPbe/0o5sFSxIJUobbHC2pcffJ9X6idC0Md8NPm1QQ+VncGgDjYll43QHZBJ6DU doPafGRxQGkmnWuTGfFYcedmwt0iBQ0= Date: Mon, 26 Sep 2022 20:40:34 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 07/10] x86/mtrr: simplify mtrr_bp_init() Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220908084914.21703-8-jgross@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2022 at 10:49:11AM +0200, Juergen Gross wrote: > diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c > index 9609a0d235f8..956838bb4481 100644 > --- a/arch/x86/kernel/cpu/mtrr/mtrr.c > +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c > @@ -761,13 +761,10 @@ void __init mtrr_bp_init(void) > mtrr_enabled = get_mtrr_state(); > > if (mtrr_enabled) { > - mtrr_bp_pat_init(); > cache_generic |= CACHE_GENERIC_MTRR | > CACHE_GENERIC_PAT; > - } > - > - if (mtrr_cleanup(phys_addr)) { > - changed_by_mtrr_cleanup = 1; > + changed_by_mtrr_cleanup = > + mtrr_cleanup(phys_addr); Just let those lines stick out. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette