From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0988C32771 for ; Mon, 26 Sep 2022 20:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbiIZUEe (ORCPT ); Mon, 26 Sep 2022 16:04:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbiIZUEb (ORCPT ); Mon, 26 Sep 2022 16:04:31 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A66D97B16; Mon, 26 Sep 2022 13:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=BO41jb632AO2Bc9BLgoCYD5efImi2YwyYT9pGgQE7og=; b=P8 8uiuSD2+ubN4vwqv6s1SPc9Rxq53k4mdI4L3mMk6z78YdQVeiwmkVixTzfuDkJsbnNfd5DQudJiF6 TF5XCRN/T1P63gzgMhkJAnCjshmQEvssaPnVBRe3I7e6Rt0N/nyyuSAUXlrd0CkA4Aj40A0XZmzkP 4+eGFSHxDsICwtc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ocuKz-000L1E-80; Mon, 26 Sep 2022 22:04:21 +0200 Date: Mon, 26 Sep 2022 22:04:21 +0200 From: Andrew Lunn To: Rob Herring Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Liam Girdwood , Mark Brown , Gregory Clement , Sebastian Hesselbarth , Marcin Wojtas , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms Message-ID: References: <20220920132648.2008-1-pali@kernel.org> <20220920132648.2008-2-pali@kernel.org> <20220926194832.GA2668987-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220926194832.GA2668987-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 02:48:32PM -0500, Rob Herring wrote: > On Tue, Sep 20, 2022 at 03:26:44PM +0200, Pali Rohár wrote: > > From: Marcin Wojtas > > > > The audio unit of Marvell Armada38x SoC is similar to the ones comprised by > > other Marvell SoCs (Kirkwood, Dove and Armada 370). Therefore KW audio > > driver can be used to support it and this commit adds new compatible string > > to identify Armada 38x variant. > > > > Two new memory regions are added: first one for PLL configuration and > > the second one for choosing one of audio I/O modes (I2S or S/PDIF). > > For the latter purpose a new optional DT property is added ('spdif-mode'). > > > > kirkwood-i2s driver is extended by adding a new init function for Armada > > 38x flavor and also a routine that enables PLL output (i.e. MCLK) > > configuration. > > > > Signed-off-by: Marcin Wojtas > > Tested-by: Star_Automation > > Reviewed-by: Nadav Haklai > > Reviewed-by: Lior Amsalem > > Tested-by: Lior Amsalem > > Signed-off-by: Hezi Shahmoon > > Reviewed-by: Neta Zur Hershkovits > > [pali: Fix support for pre-38x SoCs] > > Signed-off-by: Pali Rohár > > --- > > .../devicetree/bindings/sound/mvebu-audio.txt | 14 +- > > sound/soc/kirkwood/kirkwood-i2s.c | 136 +++++++++++++++++- > > sound/soc/kirkwood/kirkwood.h | 2 + > > 3 files changed, 149 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/mvebu-audio.txt b/Documentation/devicetree/bindings/sound/mvebu-audio.txt > > index cb8c07c81ce4..4f5dec5cb3c2 100644 > > --- a/Documentation/devicetree/bindings/sound/mvebu-audio.txt > > +++ b/Documentation/devicetree/bindings/sound/mvebu-audio.txt > > @@ -6,9 +6,14 @@ Required properties: > > "marvell,kirkwood-audio" for Kirkwood platforms > > "marvell,dove-audio" for Dove platforms > > "marvell,armada370-audio" for Armada 370 platforms > > + "marvell,armada-380-audio" for Armada 38x platforms > > Perhaps be consistent with the 370 string above it. Hi Rob That was something i also considered. But actually, all 380 compatibles use armada-380-FOOBAR. So this is inconsistent with armada370-audio, but consistent with armada-380 in general. Andrew