From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CBDC54EE9 for ; Tue, 27 Sep 2022 09:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230358AbiI0JHr (ORCPT ); Tue, 27 Sep 2022 05:07:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230017AbiI0JHo (ORCPT ); Tue, 27 Sep 2022 05:07:44 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62ADBABF3C for ; Tue, 27 Sep 2022 02:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664269663; x=1695805663; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mEs1ThP+kC10kNoB9YRJfORAHDJ58YH9nQ23tCVF51s=; b=BNEPXF8hQ5H1HrzelZIis+P/hsIPtsyNlEnQYs1UQGdNydVVjMQOnRwJ 2FkK5GFZtB9IzWlPoJUkWGG4jRqAQoN+SfJ4F0FJxWWgmPdxNwRummLsY WWGPu+AAMvc3lzP6OKN6C4iQAoblIdL38nxNSuuzuKha3PAA+IBMTLoNY QpX1Hx//lJpJ8SNqoTm2A8N6r5N6xn16GwqsUu1oLMq9bRpaWKFiyJuWW 6ihXD/o6ZKxN1tdtJarTUV7fY4EzTdhB6OOjggXaPiF7XfeTbwvfE/D+J XNqve7P7Raqc6bXtW2I9iB5DeafATsVJ2/U88Xquc9dd2dfLg2zX4E4Bn w==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="284391711" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="284391711" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 02:07:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="763806464" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="763806464" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 27 Sep 2022 02:07:39 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 27 Sep 2022 12:07:38 +0300 Date: Tue, 27 Sep 2022 12:07:38 +0300 From: Heikki Krogerus To: Won Chung Cc: bleung@google.com, pmalani@chromium.org, imre.deak@intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/sysfs: Link DRM connectors to corresponding Type-C connectors Message-ID: References: <20220926214157.843812-1-wonchung@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926214157.843812-1-wonchung@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 09:41:57PM +0000, Won Chung wrote: > Create a symlink pointing to USB Type-C connector for DRM connectors > when they are created. The link will be created only if the firmware is > able to describe the connection beween the two connectors. > > Signed-off-by: Won Chung Acked-by: Heikki Krogerus > --- > Changes from v1: > - Fix multiple lines to single line > > > drivers/gpu/drm/drm_sysfs.c | 40 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c > index 430e00b16eec..6a9904fa9186 100644 > --- a/drivers/gpu/drm/drm_sysfs.c > +++ b/drivers/gpu/drm/drm_sysfs.c > @@ -11,12 +11,14 @@ > */ > > #include > +#include > #include > #include > #include > #include > #include > #include > +#include > #include > > #include > @@ -95,6 +97,34 @@ static char *drm_devnode(struct device *dev, umode_t *mode) > return kasprintf(GFP_KERNEL, "dri/%s", dev_name(dev)); > } > > +static int typec_connector_bind(struct device *dev, > + struct device *typec_connector, void *data) > +{ > + int ret; > + > + ret = sysfs_create_link(&dev->kobj, &typec_connector->kobj, "typec_connector"); > + if (ret) > + return ret; > + > + ret = sysfs_create_link(&typec_connector->kobj, &dev->kobj, "drm_connector"); > + if (ret) > + sysfs_remove_link(&dev->kobj, "typec_connector"); > + > + return ret; > +} > + > +static void typec_connector_unbind(struct device *dev, > + struct device *typec_connector, void *data) > +{ > + sysfs_remove_link(&typec_connector->kobj, "drm_connector"); > + sysfs_remove_link(&dev->kobj, "typec_connector"); > +} > + > +static const struct component_ops typec_connector_ops = { > + .bind = typec_connector_bind, > + .unbind = typec_connector_unbind, > +}; > + > static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810"); > > /** > @@ -355,6 +385,13 @@ int drm_sysfs_connector_add(struct drm_connector *connector) > if (connector->ddc) > return sysfs_create_link(&connector->kdev->kobj, > &connector->ddc->dev.kobj, "ddc"); > + > + if (dev_fwnode(kdev)) { > + r = component_add(kdev, &typec_connector_ops); > + if (r) > + drm_err(dev, "failed to add component\n"); > + } > + > return 0; > > err_free: > @@ -367,6 +404,9 @@ void drm_sysfs_connector_remove(struct drm_connector *connector) > if (!connector->kdev) > return; > > + if (dev_fwnode(connector->kdev)) > + component_del(connector->kdev, &typec_connector_ops); > + > if (connector->ddc) > sysfs_remove_link(&connector->kdev->kobj, "ddc"); > thanks, -- heikki