From: Jason Gunthorpe <jgg@ziepe.ca>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: zyjzyj2000@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Bob Pearson <rpearsonhpe@gmail.com>
Subject: Re: [PATCH jgg-for-next] RDMA/rxe: Fix pd refcount_t: underflow; use-after-free
Date: Tue, 27 Sep 2022 10:14:31 -0300 [thread overview]
Message-ID: <YzL3N533TE8T3k1c@ziepe.ca> (raw)
In-Reply-To: <20220927052530.21397-1-lizhijian@fujitsu.com>
On Tue, Sep 27, 2022 at 01:25:30PM +0800, Li Zhijian wrote:
> In the error path, both rxe_put(pd) and rxe_cleanup(mr) will
> drop pd's ref_cont.
> rxe_cleanup(mr)
> -> __rxe_cleanup
> -> rxe_put(mr->elem)
> -> rxe_mr_cleanup(mr)
> -> rxe_put(mr_pd(mr))
>
> [342431.583189] ------------[ cut here ]------------
> [342431.585051] refcount_t: underflow; use-after-free.
> [342431.586677] WARNING: CPU: 0 PID: 660500 at lib/refcount.c:28 refcount_warn_saturate+0xcd/0x120
> [342431.605247] RIP: 0010:refcount_warn_saturate+0xcd/0x120
> [342431.661981] __rxe_cleanup+0x1c3/0x1e0 [rdma_rxe]
> [342431.663260] rxe_dealloc_pd+0x16/0x20 [rdma_rxe]
> [342431.664883] ib_dealloc_pd_user+0x95/0xd0 [ib_core]
> [342431.666803] destroy_hw_idr_uobject+0x46/0x90 [ib_uverbs]
> [342431.668514] uverbs_destroy_uobject+0xc8/0x360 [ib_uverbs]
> [342431.670232] __uverbs_cleanup_ufile+0x157/0x210 [ib_uverbs]
> [342431.671920] ? uverbs_destroy_uobject+0x360/0x360 [ib_uverbs]
>
> CC: Bob Pearson <rpearsonhpe@gmail.com>
> Fixes: 0d0e4b528c3b ("RDMA/rxe: Set pd early in mr alloc routines")
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> I have to say i made a mistake in previous review, I missed this WARN_ONCE messages.
> And the V6 patch that i had applied fix this problem in another way.
Does this mean I took the wrong patch? The patchworks got messed up
for this series somehow
I'll squash this diff in..
Jason
prev parent reply other threads:[~2022-09-27 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 5:25 Li Zhijian
2022-09-27 13:14 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzL3N533TE8T3k1c@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®