From: Johannes Weiner <hannes@cmpxchg.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: surenb@google.com, mingo@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/psi: Use task->psi_flags to clear in CPU migration
Date: Tue, 27 Sep 2022 09:39:03 -0400 [thread overview]
Message-ID: <YzL89wKVbIn8y/QF@cmpxchg.org> (raw)
In-Reply-To: <20220926081931.45420-1-zhouchengming@bytedance.com>
On Mon, Sep 26, 2022 at 04:19:31PM +0800, Chengming Zhou wrote:
> The commit d583d360a620 ("psi: Fix psi state corruption when schedule()
> races with cgroup move") fixed a race problem by making cgroup_move_task()
> use task->psi_flags instead of looking at the scheduler state.
>
> We can extend task->psi_flags usage to CPU migration, which should be
> a minor optimization for performance and code simplicity.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Nice one!
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2022-09-27 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 8:19 Chengming Zhou
2022-09-27 13:39 ` Johannes Weiner [this message]
2022-10-31 10:53 ` [tip: sched/core] " tip-bot2 for Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzL89wKVbIn8y/QF@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=surenb@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®