From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5431C07E9D for ; Tue, 27 Sep 2022 11:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbiI0L3I (ORCPT ); Tue, 27 Sep 2022 07:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232064AbiI0L14 (ORCPT ); Tue, 27 Sep 2022 07:27:56 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBCAA14D325 for ; Tue, 27 Sep 2022 04:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h/MydmqVDnPt6+f27hhhnktf+VsTmJD1gi7+Db/6BfI=; b=DzERKva0wO6ot7cHj4artBe64N 14uwKlXGuxUGglPtEUdPWdJK3aFNEfGa5QA5jj5+7SeJCnStNP2SSmL2RPeL444vtpR4+wz1reEhb EbcI1g5V+L1JMWUVQnDgRCj8Q81OhosysNmYh+Br/uppOS5sutNHN30q6bT0H5rP8LIIFpdQCvIjc wmdzhFjt1jjw/LAYdiyFcqCEmzEi2AnwOnGqjAP+ioQdbxb9wiYLWrOKUuo/kTeUvQmAzGt1JuEUu 0Wbk5KY7U6aV0UZlG/f2Y+N2AtBjZ1T6M39S8OWyc186M7Y0GGmBEvEz4n5ohzSDCoCLfkBpueN7t F6nC3gww==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1od8is-00GH6W-Aw; Tue, 27 Sep 2022 11:25:58 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3C9A630024D; Tue, 27 Sep 2022 13:25:57 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1E7F22BDDB529; Tue, 27 Sep 2022 13:25:57 +0200 (CEST) Date: Tue, 27 Sep 2022 13:25:57 +0200 From: Peter Zijlstra To: Ricardo Neri Cc: Juri Lelli , Vincent Guittot , Ricardo Neri , "Ravi V. Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J. Wysocki" , Srinivas Pandruvada , Steven Rostedt , Tim Chen , Valentin Schneider , x86@kernel.org, linux-kernel@vger.kernel.org, "Tim C . Chen" Subject: Re: [RFC PATCH 10/23] sched/fair: Use classes of tasks when selecting a busiest runqueue Message-ID: References: <20220909231205.14009-1-ricardo.neri-calderon@linux.intel.com> <20220909231205.14009-11-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909231205.14009-11-ricardo.neri-calderon@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2022 at 04:11:52PM -0700, Ricardo Neri wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 7368a0b453ee..085b1f75d90b 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -10009,6 +10009,7 @@ static struct rq *find_busiest_queue(struct lb_env *env, > int i; > > for_each_cpu_and(i, sched_group_span(group), env->cpus) { > + int busiest_class_delta_score = INT_MIN; You sure you want to break ties toward a negative IPC 'improvement' ? > unsigned long capacity, load, util; > unsigned int nr_running; > enum fbq_type rt; > @@ -10118,6 +10119,20 @@ static struct rq *find_busiest_queue(struct lb_env *env, > if (busiest_nr < nr_running) { > busiest_nr = nr_running; > busiest = rq; > + } else if (sched_task_classes_enabled() && > + busiest_nr == nr_running) { > + int curr_class_delta_score; > + > + curr_class_delta_score = arch_get_task_class_score(rq->curr->class, > + env->dst_cpu) - > + arch_get_task_class_score(rq->curr->class, > + cpu_of(rq)); *sigh*, you really couldn't find a more ugly layout if you tried. Perhaps use less than novella length identifiers? > + > + if (busiest_class_delta_score < curr_class_delta_score) { > + busiest_class_delta_score = curr_class_delta_score; > + busiest_nr = nr_running; > + busiest = rq; > + } > } > break;