From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38013C6FA82 for ; Tue, 27 Sep 2022 11:59:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbiI0L7i (ORCPT ); Tue, 27 Sep 2022 07:59:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbiI0L7d (ORCPT ); Tue, 27 Sep 2022 07:59:33 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D23774E23 for ; Tue, 27 Sep 2022 04:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=icSRnCoa38KYWodS1KJV18+kpFMUC/PtthRr0+r/Edo=; b=Flav9QFbDX3Q8+UYnVPuCpnmsv L8fJeFrb9Kf/5IwesrifQi8Fd2Mvfy6x/t8IuXHSmL9AR8zglzTKBTgTalo/rwYxTI+jbjYgCbuC9 TVUWcON+CBDXYzz+8udZPaDyYoYmTD7N6iKEonOtmlXhWexeARjpAXyA1R8fymi+lIGSNiWWekF6y GOHkylLNKAzgiieVJmkNobPVvJe/rQbCrkXwP0dtduiHhHxKFS3Zz40z3QGO1L2B4Q0ejR768pedK 7avs5oz1cOAWiCjnYkeZww8ReubKIb5YXmzEN3rwZSz547XHM2HN/Bt9nKXGgnCz3ey+cdy6zh5lD x0wQPTaA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1od9F6-00GHPa-M3; Tue, 27 Sep 2022 11:59:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 12C4C300205; Tue, 27 Sep 2022 13:59:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E38A72BDDA85A; Tue, 27 Sep 2022 13:59:15 +0200 (CEST) Date: Tue, 27 Sep 2022 13:59:15 +0200 From: Peter Zijlstra To: Ricardo Neri Cc: Juri Lelli , Vincent Guittot , Ricardo Neri , "Ravi V. Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J. Wysocki" , Srinivas Pandruvada , Steven Rostedt , Tim Chen , Valentin Schneider , x86@kernel.org, linux-kernel@vger.kernel.org, "Tim C . Chen" Subject: Re: [RFC PATCH 15/23] thermal: intel: hfi: Report per-cpu class-specific performance scores Message-ID: References: <20220909231205.14009-1-ricardo.neri-calderon@linux.intel.com> <20220909231205.14009-16-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909231205.14009-16-ricardo.neri-calderon@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2022 at 04:11:57PM -0700, Ricardo Neri wrote: > Support the arch_get_task_class_score() interface of the scheduler. Use the > data that Intel Thread Director provides to inform the scheduler the > performance of a class of tasks when placed on a given CPU. > > +static void get_one_hfi_cap(struct hfi_instance *hfi_instance, s16 index, > + struct hfi_cpu_data *hfi_caps, int class) > +{ > + struct hfi_cpu_data *caps; > + > + /* Find the capabilities of @cpu */ > + caps = hfi_instance->data + index * hfi_features.cpu_stride + > + class * hfi_features.class_stride; > + memcpy(hfi_caps, caps, sizeof(*hfi_caps)); > +} > + > +int intel_hfi_get_task_class_score(int class, int cpu) > +{ > + struct hfi_cpu_info *info = &per_cpu(hfi_cpu_info, cpu); > + struct hfi_instance *instance; > + struct hfi_cpu_data caps; > + unsigned long flags; > + int cap; > + > + if (cpu < 0 || cpu >= nr_cpu_ids) > + return -EINVAL; > + > + if (class == TASK_CLASS_UNCLASSIFIED) > + return -EINVAL; > + > + if (class >= (int)hfi_features.nr_classes) > + return -EINVAL; > + > + instance = info->hfi_instance; > + if (!instance) > + return -ENOENT; > + > + raw_spin_lock_irqsave(&instance->table_lock, flags); > + get_one_hfi_cap(instance, info->index, &caps, class); > + cap = caps.perf_cap; > + raw_spin_unlock_irqrestore(&instance->table_lock, flags); > + > + return cap; > +} Does any of that data actually ever change? Isn't the class score fixed per CPU type?