On Wed, Sep 14, 2022 at 04:37:46PM +0800, Jilin Yuan wrote: > -/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */ > +/* The actual GPIO offsets get filled in the palm27x_udc_init() call */ > static struct gpiod_lookup_table palm27x_udc_gpiod_table = { > .dev_id = "gpio-vbus", > .table = { NAK! The reasons: * I read the comment above (without the patch) as "The actual offsets get set in the function call". Both ins are of different parts of speech (adverbial and preposition). * As I stated to other developers (see [1] and [2]), you and other @cdjrlc.com developers ignore critical code reviews (no reply to them). Thanks. [1]: https://lore.kernel.org/lkml/ca8efe3b-1aeb-8a4e-79e9-3f3f9281ff34@gmail.com/ [2]: https://lore.kernel.org/lkml/YzJaIolrTarQ4Qdn@debian.me/ -- An old man doll... just what I always wanted! - Clara