From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5B3C54EE9 for ; Tue, 27 Sep 2022 20:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232968AbiI0UrG (ORCPT ); Tue, 27 Sep 2022 16:47:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230061AbiI0Uqn (ORCPT ); Tue, 27 Sep 2022 16:46:43 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47357107DC1; Tue, 27 Sep 2022 13:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t9fdahaIlTbuuw4gBOVz0mj5oYRa25j90QOIBaBUK4Y=; b=SgH3Z9oJqaAY/hI4xOawkOVGMP Ql52FHE88nF6mcDoTmY7kX1ans4xJmdgvv8ZjV4sXUzjaVyNn1eow1p61IQXsNagqhyw8i11JFLd8 8UE/+0Kdr+4nvvAPAxtxvzfbq5zvah+BeRqbyAOf4Bj8NXotes4+MCLR+QWHmsrv17FCwgxrMPbv5 sjtVSMX+px2dteU7oIznrmBczdXBib+dAxX2uhsDFc2uoZkXr0NppfK9uxRZOdN/dBb2AdGJv7Kgo sdJjyuR3ya4wmhDBeSW0Y1w+3ezBtPB0vkivQ6tGKrfmU2kvOgWcSGAMED/F2x1G3f7Owi/ebYvUq 83EtPP8A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1odHT4-00GNk8-15; Tue, 27 Sep 2022 20:46:14 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D3CCB3001F3; Tue, 27 Sep 2022 22:46:12 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B02A82BE0F540; Tue, 27 Sep 2022 22:46:12 +0200 (CEST) Date: Tue, 27 Sep 2022 22:46:12 +0200 From: Peter Zijlstra To: Jiri Olsa Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Kan Liang , lkml , Ingo Molnar , Alexander Shishkin , Mark Rutland , Namhyung Kim , bpf@vger.kernel.org, Song Liu , Daniel Xu Subject: Re: [PATCH -tip] bpf: Check flags for branch stack in bpf_read_branch_records helper Message-ID: References: <20220927203259.590950-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927203259.590950-1-jolsa@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022 at 10:32:59PM +0200, Jiri Olsa wrote: > Recent commit [1] changed branch stack data indication from > br_stack pointer to sample_flags in perf_sample_data struct. > > We need to check sample_flags for PERF_SAMPLE_BRANCH_STACK > bit for valid branch stack data. > > [1] a9a931e26668 ("perf: Use sample_flags for branch stack") > > Cc: Kan Liang > Fixes: a9a931e26668 ("perf: Use sample_flags for branch stack") > Signed-off-by: Jiri Olsa > --- > NOTE sending on top of tip/master because [1] is not > merged in bpf-next/master yet Shall I stick this in tip/perf/core right along with [1] then?