From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27716C04A95 for ; Wed, 28 Sep 2022 15:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234552AbiI1P7U (ORCPT ); Wed, 28 Sep 2022 11:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233408AbiI1P64 (ORCPT ); Wed, 28 Sep 2022 11:58:56 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26AB0E3EF4; Wed, 28 Sep 2022 08:58:12 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E8DC747C; Wed, 28 Sep 2022 17:58:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1664380690; bh=d4aeRqyj8cvrUyW8hXIk3lH+fIMhuD/VGVgGbzpZaTw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=krVVM+TppDPUODjD6f+M70aOOt39hmoc530gGq6/v+KrOdJq6qzTwqISUNlbBNC1f XAmWFo3bGVwE6Q2h3bNSLijZYBjyNeie6SBianNIKtOmD4/aBcvoWnJ2bsLSCGBbvl ph+8yBzeM32SbaMyIVIe153yfjv0nVMcSylGoRDI= Date: Wed, 28 Sep 2022 18:58:08 +0300 From: Laurent Pinchart To: Sai Krishna Potthuri Cc: Linus Walleij , Rob Herring , Michal Simek , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, git@xilinx.com, saikrishna12468@gmail.com Subject: Re: [PATCH 0/4] pinctrl: pinctrl-zynqmp: Add tri-state configuration support Message-ID: References: <1655462819-28801-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1655462819-28801-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sai, On Fri, Jun 17, 2022 at 04:16:55PM +0530, Sai Krishna Potthuri wrote: > This series update the Xilinx firmware, ZynqMP dt-binding and ZynqMP > pinctrl driver to handle 'output-enable' and 'bias-high-impedance' > configurations. As part of these configurations, ZynqMP pinctrl driver > takes care of pin tri-state setting. > Also fix the kernel doc warning in ZynqMP pinctrl driver. I'm afraid this causes a regression :-( With this series applied, boot breaks with the following message being printed to the serial console: Received exception MSR: 0x200, EAR: 0xFF180198, EDR: 0x0, ESR: 0x64 I've traced that to the probe of the UART, when it calls into the firmware to set pin MIO18 to high impedance. According to v1.7 of the ZynqMP registers reference (UG1087), there is no register at address 0xFF180198. I am using the VCU TRD 2021.1 for testing. Does this series require a firmware update ? If so backward compatibility needs to be preserved. It's very late in the v6.0-rc cycle for a fix, a revert may be best at this point, to give us time to fix the issue properly. > Note: Resending the series as i see this series didn't went out due > to some issue with my mail client. Please ignore if this series is > already received. > > Sai Krishna Potthuri (4): > firmware: xilinx: Add configuration values for tri-state > dt-bindings: pinctrl-zynqmp: Add output-enable configuration > pinctrl: pinctrl-zynqmp: Add support for output-enable and > bias-high-impedance > pinctrl: pinctrl-zynqmp: Fix kernel-doc warning > > .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 4 ++++ > drivers/pinctrl/pinctrl-zynqmp.c | 11 +++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 5 +++++ > 3 files changed, 20 insertions(+) -- Regards, Laurent Pinchart