From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32B0C433F5 for ; Thu, 29 Sep 2022 16:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235808AbiI2QL1 (ORCPT ); Thu, 29 Sep 2022 12:11:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234737AbiI2QLY (ORCPT ); Thu, 29 Sep 2022 12:11:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1D771D2D28 for ; Thu, 29 Sep 2022 09:11:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4083061A60 for ; Thu, 29 Sep 2022 16:11:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6583C433D6; Thu, 29 Sep 2022 16:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664467882; bh=YQ2VBsdrbmdPy2lXy7ot5iuJYzQlEhfs7SsBIKRXys0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EIiXGJaWxiVEK7X2NAyW+d/K6UeALMRP5UlZu5D/jYoqbAmGXNDzv/Y20YziT2HIH VueM46Fqx1jwmmpB0RtTnFQXf54vSZf4HvO8hSpXJKylMbkhya2nJd3ceYoEwHrZ+b HRZcZlwA6YvAr8MTVFHSDZX25Q0JHnBXN8qGKSXnsIJp70DrelwBnXwyhPesBQ47gm YH7R5AFs5g8+tMucOIcfZ3NrS8Adnt1Kl6HMmkvlF0vM9daU5BzAT7jge2N8jcfL+Q Bx4xR5htE9VIukaJeLeN8dRKyCt0N7YSTrqHusSOYOutV3dB1idDjYbC6Ec1wfsamg UfTL446k0S+nw== Date: Fri, 30 Sep 2022 00:01:42 +0800 From: Jisheng Zhang To: Guo Ren Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 4/4] riscv: entry: consolidate general regs saving into save_gp Message-ID: References: <20220928162007.3791-1-jszhang@kernel.org> <20220928162007.3791-5-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 11:59:00AM +0800, Guo Ren wrote: > On Thu, Sep 29, 2022 at 12:29 AM Jisheng Zhang wrote: > > > > Consolidate the saving/restoring GPs(except ra, sp and tp) into > > save_gp/restore_gp macro. > > > > No functional change intended. > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/riscv/include/asm/asm.h | 65 +++++++++++++++++++++++++ > > arch/riscv/kernel/entry.S | 87 ++-------------------------------- > > arch/riscv/kernel/mcount-dyn.S | 58 +---------------------- > > 3 files changed, 70 insertions(+), 140 deletions(-) > > > > diff --git a/arch/riscv/include/asm/asm.h b/arch/riscv/include/asm/asm.h > > index 1b471ff73178..2f3b49536e9d 100644 > > --- a/arch/riscv/include/asm/asm.h > > +++ b/arch/riscv/include/asm/asm.h > > @@ -68,6 +68,7 @@ > > #endif > > > > #ifdef __ASSEMBLY__ > > +#include > > > > /* Common assembly source macros */ > > > > @@ -80,6 +81,70 @@ > > .endr > > .endm > > > > + /* save all GPs except ra, sp and tp */ > > + .macro save_gp > How about leave x3(gp) out of the macro, and define: > .marco save_from_x5_to_x31 > .marco restore_from_x5_to_x31 Good idea, will do in next version. Thanks