From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888F7C433F5 for ; Thu, 29 Sep 2022 17:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233318AbiI2RuF (ORCPT ); Thu, 29 Sep 2022 13:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232599AbiI2RuB (ORCPT ); Thu, 29 Sep 2022 13:50:01 -0400 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 879371E71A for ; Thu, 29 Sep 2022 10:49:59 -0700 (PDT) Received: by mail-qv1-xf2f.google.com with SMTP id ml1so1376694qvb.1 for ; Thu, 29 Sep 2022 10:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=xa8hoH9SnDPlJIeXGYh843CRJD1tjWdMf/dTq8TipPM=; b=TTqX1qhbwY8oXLjTYWELHEsRERRC+tYA4I14qRpviPTnMPxxd/vPEPS/znbsofO0+c 4bwTdW8+z/pWbH07euOuLtVPnrXYN4FM3+Cx3+6df9BnwzMRVSyQ1vC15hIyhMjMipuQ qlzZ7Fu4h7IQcnc4aD13PnswpHL+dCBN4e0DgSfgytTo+Borsg650FpgD3ZVlkkzogU1 opPTvDdjbXUTLZKa0F4b83jrDhZt81cEI/hRhpm0Bun+0Wq7SRl0wOcvarlvT3D7N0e1 b7XskLXtlA/O+SKSR/BQgRPL969bnpg4P6x3JIZubcOO7fHzsFTljemfyNnz/GZSpyiX iL9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=xa8hoH9SnDPlJIeXGYh843CRJD1tjWdMf/dTq8TipPM=; b=a7ytP2NJWk/sxUKEZX8cFxkw/ZIxY+4GMyANntqGMuMpUiTpzEnVwNrAndylPcHc6u wuf/Qm0T0Q1aDiXpr4/IQeZJ1tOIx10/nRWVcCNunyMWLmrjTK6T2PobDF8YW9Y4kpXw V4zPhAtCA+XhmOHAWw+jbWYgzAbTBEuaIwipg7KzxLNjfeBDms1U+yLVAHmsyW8eiHLC Aa27F+XnZSP7+ruGEP2QW0qV2LfEwZmUQZH+9j9Eozp50RUtIS+dLRmd6ADtO/skHhXi 2ixs9lDoHGEd1pcYt40iO3oPZ43L2gxO9ahsVOaqMQfBuLx/PDOlCK4aHHTw4JB58Xqx cirw== X-Gm-Message-State: ACrzQf2C5wlRss6VzrhZi4N8wfqfufMmdXj6r5x8quGwIGzwWqzvfnz0 FwNARGzF3QWh8j9rjwTCceJi9Q== X-Google-Smtp-Source: AMsMyM7Xarezc23TZVeEEbR3Uk9puQBAc1mIn47qgL8JGhJP31afpTjPWuOiERJgd9lOx+IPbEN2Vg== X-Received: by 2002:a05:6214:3006:b0:496:ad87:6784 with SMTP id ke6-20020a056214300600b00496ad876784mr3557984qvb.7.1664473798680; Thu, 29 Sep 2022 10:49:58 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id 85-20020a370758000000b006ceb8f36302sm6929qkh.71.2022.09.29.10.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 10:49:57 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1odxfY-003fcM-BW; Thu, 29 Sep 2022 14:49:56 -0300 Date: Thu, 29 Sep 2022 14:49:56 -0300 From: Jason Gunthorpe To: Alex Williamson Cc: Kevin Tian , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , Diana Craciun , Cornelia Huck , Longfang Liu , Shameer Kolothum , Yishai Hadas , Eric Auger , Kirti Wankhede , Leon Romanovsky , Abhishek Sahu , Christoph Hellwig , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Yi Liu Subject: Re: [PATCH v4 15/15] vfio: Add struct device to vfio_device Message-ID: References: <20220921104401.38898-1-kevin.tian@intel.com> <20220921104401.38898-16-kevin.tian@intel.com> <20220929105519.5c9ae1d8.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929105519.5c9ae1d8.alex.williamson@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 10:55:19AM -0600, Alex Williamson wrote: > Hi Kevin, > > This introduced the regression discovered here: > > https://lore.kernel.org/all/20220928125650.0a2ea297.alex.williamson@redhat.com/ > > Seems we're not releasing the resources when removing an mdev. This is > a regression, so it needs to be fixed or reverted before the merge > window. Thanks, My guess at the fix for this: https://lore.kernel.org/r/0-v1-013609965fe8+9d-vfio_gvt_unregister_jgg@nvidia.com Jason