From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FBBC433FE for ; Thu, 29 Sep 2022 21:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbiI2V11 (ORCPT ); Thu, 29 Sep 2022 17:27:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbiI2V1W (ORCPT ); Thu, 29 Sep 2022 17:27:22 -0400 Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [71.19.156.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 331A71449E7; Thu, 29 Sep 2022 14:27:21 -0700 (PDT) Received: from hatter.bewilderbeest.net (97-113-250-99.tukw.qwest.net [97.113.250.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id 850171AE; Thu, 29 Sep 2022 14:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1664486840; bh=b7ggKpXybDmgL6F0AfyIfdapD1XXHgq7iG/LCrC6YMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W1bS9uCT4yzKF9g2hLBcpxmkYOCrohSo0u/NEbH7fy2PKJULKmzgIL1DjF52KB2Ni tFSRXFT/8b8yCUIoHbOUZYbVaBOlZAtFISGYDJBC40ntxyJ9sZFny1ibpsWFgFspun tUmLXfEcjiU//IihfLDO2I7geZc+hk+XmfbbJx0Q= Date: Thu, 29 Sep 2022 14:27:19 -0700 From: Zev Weiss To: Rob Herring Cc: Mark Brown , Liam Girdwood , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Naresh Solanki , Patrick Rudolph , Laxman Dewangan , openbmc@lists.ozlabs.org Subject: Re: [PATCH 2/3] dt-bindings: regulator: Add regulator-output binding Message-ID: References: <20220925220319.12572-1-zev@bewilderbeest.net> <20220925220319.12572-3-zev@bewilderbeest.net> <20220929210714.GA2684335-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220929210714.GA2684335-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 02:07:14PM PDT, Rob Herring wrote: >On Sun, Sep 25, 2022 at 03:03:18PM -0700, Zev Weiss wrote: >> This describes a power output supplied by a regulator, such as a >> power outlet on a power distribution unit (PDU). >> >> Signed-off-by: Zev Weiss >> --- >> .../bindings/regulator/regulator-output.yaml | 47 +++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/regulator/regulator-output.yaml >> >> diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml >> new file mode 100644 >> index 000000000000..40953ec48e9e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + >> +$id: http://devicetree.org/schemas/regulator/regulator-output.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Regulator output connector >> + >> +maintainers: >> + - Zev Weiss >> + >> +description: | >> + This describes a power output connector supplied by a regulator, >> + such as a power outlet on a power distribution unit (PDU). The >> + connector may be standalone or merely one channel or set of pins >> + within a ganged physical connector carrying multiple independent >> + power outputs. >> + >> +properties: >> + compatible: >> + const: regulator-output >> + >> + vout-supply: >> + description: >> + Phandle of the regulator supplying the output. >> + >> + regulator-leave-on: >> + description: | >> + If the regulator is enabled when software relinquishes control >> + of it (such as when shutting down) it should be left enabled >> + instead of being turned off. >> + type: boolean > >I'm not too sure about this one as there could be various times when >control is relinquished. It is userspace closing its access? >driver unbind? module unload? Does a bootloader pay attention to this? > >Rob Thanks for the feedback, Rob -- I'll admit I was a bit unsure how to approach that, and this may well not be the right answer. What I'm really aiming for is an appropriate way to express that regulator on/off state should only ever be changed by explicit (external, e.g. userspace) request, never as any sort of default/automatic action. The two obvious things to guard against there seem to be automatic enablement during initialization and automatic disablement on de-init (shutdown, unbind, etc.). The former I think can be avoided by simply not setting regulator-boot-on, so I added this as a corresponding property to avoid the latter. I'm definitely open to suggestions for a better approach though. Thanks, Zev