From: Sakari Ailus <sakari.ailus@iki.fi>
To: Shravan.Chippa@microchip.com
Cc: paul.j.murphy@intel.com, daniele.alessandrelli@intel.com,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, Conor.Dooley@microchip.com,
Prakash.Battu@microchip.com
Subject: Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode
Date: Sun, 2 Oct 2022 15:28:43 +0300 [thread overview]
Message-ID: <YzmD+yNv0Ryj/8IC@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <PH0PR11MB5611B27A6A2EFA9ABD79AB5E81599@PH0PR11MB5611.namprd11.prod.outlook.com>
On Sat, Oct 01, 2022 at 08:51:46AM +0000, Shravan.Chippa@microchip.com wrote:
> > > > > + case MEDIA_BUS_FMT_SRGGB12_1X12:
> > > > > + return imx334_write_regs(imx334,
> > > > > + raw12_framefmt_regs,
> > > > > +
> > > > > + ARRAY_SIZE(raw12_framefmt_regs));
> > > >
> > > > I think you'll also need changes to the pixel clock calculation.
> > > >
> > > In this driver pixel clock read only variable.
> > > Pixel clock change maybe in different series.
> >
> > Please address it in this patch.
> >
> > Is the link frequency affected by this patch as well?
>
> I will try to modify my patch with the default link frequency available in the driver
Also check the frequencies the driver enables will be available in
link-frequencies.
--
Sakari Ailus
next prev parent reply other threads:[~2022-10-02 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 5:10 shravan kumar
2022-09-20 12:14 ` Sakari Ailus
2022-09-26 11:32 ` Shravan.Chippa
2022-09-26 16:51 ` Sakari Ailus
2022-10-01 8:51 ` Shravan.Chippa
2022-10-02 4:42 ` Shravan.Chippa
2022-10-02 12:00 ` Sakari Ailus
2022-10-02 12:28 ` Sakari Ailus [this message]
2022-10-12 9:27 ` Shravan.Chippa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzmD+yNv0Ryj/8IC@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=Conor.Dooley@microchip.com \
--cc=Prakash.Battu@microchip.com \
--cc=Shravan.Chippa@microchip.com \
--cc=daniele.alessandrelli@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®