From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7350BC433F5 for ; Tue, 4 Oct 2022 18:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbiJDSSr (ORCPT ); Tue, 4 Oct 2022 14:18:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiJDSSo (ORCPT ); Tue, 4 Oct 2022 14:18:44 -0400 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701362716D for ; Tue, 4 Oct 2022 11:18:43 -0700 (PDT) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1324e7a1284so8725344fac.10 for ; Tue, 04 Oct 2022 11:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=tm9V1W6sbJLGoKww0Pd01MWARsNl2VayTPi/yUy6mbA=; b=P4jctgCI/GCk8N2X+3D2CZj/UmgosvqGgDPnyogIk7yDx9AXjAAcDjEVT6Ut19oBNF 3CyyIV+tYjNhnzdxUC1SlqTWXLOKRAuHG+nxs/tF/uKcOjhscDHlXBiu/lNvlYiloNEn TkgjgYaDXtsHxQUA1noQFBz6Nw13S6RIagYU0BxUBC/fGY3ghgizWiyEh3ZeImPBg91k 0dwJD8qt/iarkeylORuN1e3TXHE4fsSEUx4L2m+CNKp/XEQ6Go227hZOpO/S4UOiyldm EUl5mFTRZfhGE0WUoeXabT1jWD8RVIz12E7hNXm9hVEN0Us821uTRp6ZYJBt4n/P9DGY jGVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=tm9V1W6sbJLGoKww0Pd01MWARsNl2VayTPi/yUy6mbA=; b=Bevt/Op8rROaJFBVJ+sEoqCNRjZ7OgXhX1CvcTJbS7kv2RFxNDrYXH4JgmjaI7Pmoo 9/F2Wttb3pLsU+pgL2IC0QguBudsXdvED9iEElv+oT9TkiqMZUsuL2JdlXvk3MRIVP0n TTKowg995ODz8zTyLtJzvMGGKz1c7/srDClpgZJTWp0zC2x6uAOY6WLNzPo8GBCM2ogn +2q2/79UNqNu5eaoP9EKDL5hxUTuNBZ3MD6+BnlpXxyi44926nyYghXkTfeJ8i1dghSA O6Wl42QEEMcWQpo6ElLp9dgf2+smWqOQrR+hVffUUWdTzE8pmke5k+jGECEF+9yXj0P6 OGsQ== X-Gm-Message-State: ACrzQf2/h88og2jDyxiqwCELJljRdYRNrqcy2VWkK+EQTOM9qsJFhCM+ 6h8nB+iieBJHT7XBYioGIPXkMig+ZYM= X-Google-Smtp-Source: AMsMyM7anDfeqr/svCqvngaWeYH69YhuQSKUdnLfE2jhvLJy8hyDb0njoZq2XBfTeG60OQWLgoeHAw== X-Received: by 2002:a05:6870:c38f:b0:12b:cb22:9056 with SMTP id g15-20020a056870c38f00b0012bcb229056mr594343oao.125.1664907521992; Tue, 04 Oct 2022 11:18:41 -0700 (PDT) Received: from localhost ([12.97.180.36]) by smtp.gmail.com with ESMTPSA id 62-20020aca0741000000b003539686cb7bsm1991421oih.53.2022.10.04.11.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 11:18:41 -0700 (PDT) Date: Tue, 4 Oct 2022 11:16:29 -0700 From: Yury Norov To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Rasmus Villemoes Subject: Re: [GIT PULL] bitmap changes for v6.0-rc1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 04, 2022 at 10:55:51AM -0700, Linus Torvalds wrote: > On Sun, Oct 2, 2022 at 7:03 PM Yury Norov wrote: > > > > Please pull this patches. They spent more than a week in -next without > > major problems. The only problem with warnings generated by cpumask_check(), > > when robots do bisection, is fixed by moving the patch "cpumask: fix > > checking valid cpu range" to the very end of the series. > > So I appreciate the commentary about process just to explain what's going on. > > But what I want for the merge message is a summary of what the pull > actually *does* - the process commentary is good addition, but it's > not useful for the merge commit message about what the merge actually > brings in. > > And for that, I do *not* want explanations like this: > > > This branch is based on v6.0-rc4 and includes: > > > > drivers/base: Fix unsigned comparison to -1 in CPUMAP_FILE_MAX_BYTES > > From Phil Auld > > https://lore.kernel.org/lkml/20220906203542.1796629-1-pauld@redhat.com/ > ... > > where the explanations just point to external data. > > Commit messages are supposed to be self-sufficient. External links can > be acceptable as a "this has subtle issues that are too boring and > extensive to explain here", but even then it's only for _additional_ > commentary, not a replacement for explaining what is going on. > > And those external links aren't even that. They are literally just the > "this is where the patches were posted originally". Not useful. > > So I'm dropping this as not having enough explanations of why I should > pull them. It has explanations, yes, but they are about secondary > things, not about the actual expected improvements brought in by the > pull. OK, I'll resend shortly Thanks, Yury