From: Frank Li <Frank.li@nxp.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 07/10] arm64: dts: imx8mn-beacon: Configure Ethernet PHY reset and GPIO IRQ
Date: Wed, 16 Apr 2025 10:43:16 -0400 [thread overview]
Message-ID: <Z//CBD7dVNW29JRW@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250416010141.1785841-7-aford173@gmail.com>
On Tue, Apr 15, 2025 at 08:01:33PM -0500, Adam Ford wrote:
> The Ethernet PHY setup currently assumes that the bootloader will take the
> PHY out of reset, but this behavior is not guaranteed across all
> bootloaders. Add the reset GPIO to ensure the kernel can properly control
> the PHY reset line.
>
> Also configure the PHY IRQ GPIO to enable interrupt-driven link status
> reporting, instead of relying on polling.
>
> This ensures more reliable Ethernet initialization and improves PHY event
> handling.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> V2: Update commit message. No active changes.
>
> arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi
> index bb11590473a4..b3692b367a42 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi
> @@ -88,6 +88,9 @@ mdio {
> ethphy0: ethernet-phy@0 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <0>;
> + reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
> };
> };
> };
> @@ -326,6 +329,7 @@ MX8MN_IOMUXC_ENET_TXC_ENET1_RGMII_TXC 0x1f
> MX8MN_IOMUXC_ENET_RXC_ENET1_RGMII_RXC 0x91
> MX8MN_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL 0x91
> MX8MN_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL 0x1f
> + MX8MN_IOMUXC_GPIO1_IO10_GPIO1_IO10 0x146
> MX8MN_IOMUXC_SAI2_RXC_GPIO4_IO22 0x19
> >;
> };
> --
> 2.48.1
>
next prev parent reply other threads:[~2025-04-16 14:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 1:01 [PATCH V2 01/10] arm64: dts: imx8mm-beacon: Fix RTC capacitive load Adam Ford
2025-04-16 1:01 ` [PATCH V2 02/10] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-16 14:40 ` Frank Li
2025-04-16 1:01 ` [PATCH V2 03/10] arm64: dts: imx8mp-beacon: " Adam Ford
2025-04-16 14:41 ` Frank Li
2025-04-16 1:01 ` [PATCH V2 04/10] arm64: dts: imx8mm-beacon: Set SAI5 MCLK direction to output for HDMI audio Adam Ford
2025-04-16 14:41 ` Frank Li
2025-04-16 1:01 ` [PATCH V2 05/10] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-16 14:42 ` Frank Li
2025-04-16 1:01 ` [PATCH V2 06/10] arm64: dts: imx8mm-beacon: Configure Ethernet PHY reset and GPIO IRQ Adam Ford
2025-04-16 14:42 ` Frank Li
2025-04-16 1:01 ` [PATCH V2 07/10] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-16 14:43 ` Frank Li [this message]
2025-04-16 1:01 ` [PATCH V2 08/10] arm64: dts: imx8mm-beacon: Enable RTC interrupt and wakeup-source Adam Ford
2025-04-16 14:44 ` Frank Li
2025-04-16 1:01 ` [PATCH V2 09/10] arm64: dts: imx8mn-beacon: " Adam Ford
2025-04-16 14:44 ` Frank Li
2025-04-16 1:01 ` [PATCH V2 10/10] arm64: dts: imx8mp-beacon: " Adam Ford
2025-04-25 2:07 ` [PATCH V2 01/10] arm64: dts: imx8mm-beacon: Fix RTC capacitive load Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z//CBD7dVNW29JRW@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®