From: Frank Li <Frank.li@nxp.com>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, upstream@lists.phytec.de
Subject: Re: [PATCH v2 08/15] arm64: dts: freescale: imx93-phyboard-segin: Fix SD-card pinctrl
Date: Tue, 15 Apr 2025 14:38:06 -0400 [thread overview]
Message-ID: <Z/6njgua1PB+uKEX@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250415043311.3385835-9-primoz.fiser@norik.com>
On Tue, Apr 15, 2025 at 06:33:04AM +0200, Primoz Fiser wrote:
> Until now, all usdhc2 (SD-card) pinctrl labels pointed to one pinctrl
> group "usdhc2grp" which was overwritten twice by the 100 and 200 MHz
> modes. Fix this by using unique pinctrl names.
>
> Additionally, adjust MX93_PAD_SD2_CLK__USDHC2_CLK pad drive-strength
> according to values obtained by measurements from the PHYTEC hardware
> department to improve signal integrity.
>
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Strange, DTC should report error if meet the same node name.
> ---
> Changes in v2:
> - reword commit msg
> - split errata changes into separate patch
>
> arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
> index 3d5cd0561362..541297052b62 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts
> @@ -77,7 +77,7 @@ MX93_PAD_SD2_CD_B__GPIO3_IO00 0x31e
>
> pinctrl_usdhc2_default: usdhc2grp {
> fsl,pins = <
> - MX93_PAD_SD2_CLK__USDHC2_CLK 0x179e
> + MX93_PAD_SD2_CLK__USDHC2_CLK 0x159e
> MX93_PAD_SD2_CMD__USDHC2_CMD 0x139e
> MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x138e
> MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x138e
> @@ -87,9 +87,9 @@ MX93_PAD_SD2_VSELECT__USDHC2_VSELECT 0x51e
> >;
> };
>
> - pinctrl_usdhc2_100mhz: usdhc2grp {
> + pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
> fsl,pins = <
> - MX93_PAD_SD2_CLK__USDHC2_CLK 0x179e
> + MX93_PAD_SD2_CLK__USDHC2_CLK 0x159e
> MX93_PAD_SD2_CMD__USDHC2_CMD 0x139e
> MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x138e
> MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x138e
> @@ -99,9 +99,9 @@ MX93_PAD_SD2_VSELECT__USDHC2_VSELECT 0x51e
> >;
> };
>
> - pinctrl_usdhc2_200mhz: usdhc2grp {
> + pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
> fsl,pins = <
> - MX93_PAD_SD2_CLK__USDHC2_CLK 0x178e
> + MX93_PAD_SD2_CLK__USDHC2_CLK 0x158e
> MX93_PAD_SD2_CMD__USDHC2_CMD 0x139e
> MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x139e
> MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x139e
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-04-15 18:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 4:32 [PATCH v2 00/15] Update PHYTEC i.MX93 DTS Primoz Fiser
2025-04-15 4:32 ` [PATCH v2 01/15] arm64: dts: freescale: imx93-phycore-som: Add PMIC support Primoz Fiser
2025-04-15 4:32 ` [PATCH v2 02/15] arm64: dts: freescale: imx93-phycore-som: Add EEPROM support Primoz Fiser
2025-04-15 18:30 ` Frank Li
2025-04-15 4:32 ` [PATCH v2 03/15] arm64: dts: freescale: imx93-phycore-som: Disable LED pull-up Primoz Fiser
2025-04-15 4:33 ` [PATCH v2 04/15] arm64: dts: freescale: imx93-phycore-som: Enhance eMMC pinctrl Primoz Fiser
2025-04-15 4:33 ` [PATCH v2 05/15] arm64: dts: freescale: imx93-phycore-som: Add eMMC no-1-8-v by default Primoz Fiser
2025-04-15 4:33 ` [PATCH v2 06/15] arm64: dts: freescale: imx93-phyboard-segin: Drop eMMC no-1-8-v flag Primoz Fiser
2025-04-15 4:33 ` [PATCH v2 07/15] arm64: dts: freescale: imx93-phyboard-segin: Disable SD-card write-protect Primoz Fiser
2025-04-15 18:31 ` Frank Li
2025-04-15 4:33 ` [PATCH v2 08/15] arm64: dts: freescale: imx93-phyboard-segin: Fix SD-card pinctrl Primoz Fiser
2025-04-15 18:38 ` Frank Li [this message]
2025-04-15 4:33 ` [PATCH v2 09/15] arm64: dts: freescale: imx93-phyboard-segin: Fix for ERR052021 errata Primoz Fiser
2025-04-15 18:42 ` Frank Li
2025-04-16 12:38 ` Primoz Fiser
2025-04-15 4:33 ` [PATCH v2 10/15] arm64: dts: freescale: imx93-phyboard-segin: Add RTC support Primoz Fiser
2025-04-15 18:46 ` Frank Li
2025-04-16 12:42 ` Primoz Fiser
2025-04-15 4:33 ` [PATCH v2 11/15] arm64: dts: freescale: imx93-phyboard-segin: Add CAN support Primoz Fiser
2025-04-15 18:44 ` Frank Li
2025-04-15 4:33 ` [PATCH v2 12/15] arm64: dts: freescale: imx93-phyboard-segin: Add USB support Primoz Fiser
2025-04-15 18:47 ` Frank Li
2025-04-15 4:33 ` [PATCH v2 13/15] arm64: dts: freescale: imx93-phyboard-segin: Add I2S audio Primoz Fiser
2025-04-15 6:58 ` Daniel Baluta
2025-04-15 4:33 ` [PATCH v2 14/15] arm64: dts: freescale: imx93-phyboard-segin: Add EQOS Ethernet Primoz Fiser
2025-04-15 4:33 ` [PATCH v2 15/15] arm64: dts: freescale: imx93-phyboard-segin: Order node alphabetically Primoz Fiser
2025-04-15 18:48 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/6njgua1PB+uKEX@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®