From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA0FE1EB5D4 for ; Wed, 26 Mar 2025 14:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742999646; cv=none; b=VXgbgtIUdeqcGIcJYhSbJ9pKtzuNXVANoYqppfu2Bf4r6yxsRssAMGeDrro9HRt+Uo7rUFupuuKUYSAy6nHoJ05eDQzVFZqLv88oEwtpXgdTgLPjyXFx46eadAqBlqEEoUdvFNrwEM6XYFeYcJhtXez+QrXkPYpfKfiP0jG9t28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742999646; c=relaxed/simple; bh=X9K0ZiIBbyvbHh33ELRxPX3WXyDf6Rv/bbUWC1l6rkI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nq7fK+Tb8emaDIxkGWzs1hhmTjKo65/dQiE16lgJzeLFQfwA8dzbF0ix4GD7U8O5i9SuAnAEfyttBjJcxSX+NJ4gCUFlRrwhP7gvVXvz78vZnETKyNapCqx9vIHtib78fFxB6uzpvvrtDqIHh5AGOHxAIIKoUOK53PusgVJrixE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=OsyVIHS1; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="OsyVIHS1" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7c5c815f8efso367645485a.2 for ; Wed, 26 Mar 2025 07:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1742999643; x=1743604443; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X9K0ZiIBbyvbHh33ELRxPX3WXyDf6Rv/bbUWC1l6rkI=; b=OsyVIHS1DCbkohaT8GNSyvOIwoQ7zn3xRt6+wTj3Y+r9XYdSdLiD0qgXXGl/89DTtG e8pJLVNtLWtI+dWmUpwX1e+jGg9HrKAStwSJt3jQTBSsJsA0LCGyiZkuQz66WvG2n8P1 UF+0MU8y100y7T3SS/OEE9ueHxOh1TAWznFfI7xd7tAwsXwbd0BgUf4bnx8/Wv1lhzcj hEu/D3CZTPHqVasmWzOsZqb7kIJ4a2VW9+WIDQnCdOiGGat9uqCZPyegJZ3touewr+B1 PQIqlP05CMceZZpGkEkEg66AmYZSuyJSIJYrpVsq4zjzmlfbz4+lr2k66W+gOdFeJXq8 1OZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742999643; x=1743604443; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X9K0ZiIBbyvbHh33ELRxPX3WXyDf6Rv/bbUWC1l6rkI=; b=CSukg9TfdK47v2xIlJDe53jrqKSgi56mg9mKWgbMP4vi1BOvgn+eGLJsfESdpjRfXP E2xM8Cg6v873Xq+itgOs0Z72gZVncAQkcG9FQOwysPP6fYrpy9kkcIlFv9C8vXKaGzOk ytJFkWEtlbPh6F9BU/cWWr+fsCKpyruHW0iCFodCviEULVfETl8H9Ec+Il/7eSM3uGLy s5Dk7KONkW9Jl5EO213SpL/Rf1s1DJ5+Gu7+A/lvNTdYl+32A5zSl+9fC1LeL9L3Ival HlmfodcS1doyLc1lx9b+K3JvuUkc7/qz09k36kSyqjQwcPd3PYSWV9v2G6iRXzWdYqar SA+w== X-Forwarded-Encrypted: i=1; AJvYcCUzVtqILAh+/9tmZiYk1+vG6EXkT5WeiNJeBJpkq5MPZpYqBvmjgrAlgzYBRpiVIAiakrw/bnkj/YnD3FM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw87Qov3nezMgQwI2OTQUtaDue1AfhLhbs241HdErkypoyG1eU2 k0TrVUQHlhaSVmHkIcsZf5gk+FYvs+r1Vv7W28UZoQ8mkoQ8To2wbvwwzQ3hIYY= X-Gm-Gg: ASbGncssEG6FSbq77hdV4Mbg7AFaLUQBxXl2FDKL6tatcVBF4KwGJRS36X96rEtSm7W 0U852ni2PKenDQqElBfCd8H3HyfImuCUsAGz96oyIv1qweTycORxFWG3K2V+LZUp2CTlWhAwHEe l1iUh9upUhy4JD3qivZHnP2KPlsdo8YYVaYueMw9GvmbE5PLk/aWwv4iyFIYFiDF1GQNI+sopmZ UN7WdD6kZJeFqz87xwgumK0w42yWs5EoNMifA3wir8FaRcTFFdqkOZePgRhc3iyLAOWRZR/QQ0W 1ArrU4JUtGwyzEmusw== X-Google-Smtp-Source: AGHT+IEvJNHFEY70ZCHkTf9bLLQ/xpRNZLwrrnPOmT9ZRkaQAnsvEu15xp7iNKz4p/RtU1qliO8qlA== X-Received: by 2002:a05:620a:2a08:b0:7c5:5670:bd75 with SMTP id af79cd13be357-7c5ba1e961amr3571891985a.46.1742999643403; Wed, 26 Mar 2025 07:34:03 -0700 (PDT) Received: from ziepe.ca ([99.209.85.25]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5b934831esm772669385a.80.2025.03.26.07.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 07:34:02 -0700 (PDT) Received: from jgg by jggl with local (Exim 4.95) (envelope-from ) id 1txRpR-000ATd-1m; Wed, 26 Mar 2025 11:34:01 -0300 Date: Wed, 26 Mar 2025 11:34:01 -0300 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Sumit Garg , Stefano Garzarella , linux-kernel@vger.kernel.org, Peter Huewe , linux-integrity@vger.kernel.org, James Bottomley , Jens Wiklander Subject: Re: [PATCH 2/2] tpm/tpm_ftpm_tee: use send_recv() op Message-ID: References: <20250320152433.144083-1-sgarzare@redhat.com> <20250320152433.144083-3-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 26, 2025 at 02:11:12PM +0200, Jarkko Sakkinen wrote: > Generally speaking I don't see enough value in complicating > callback interface. It's better to handle complications in > the leaves (i.e. dictatorship of majority ;-) ). That is very much not the way most driver subsystems view the world. We want to pull logical things into the core code and remove them from drivers to make the drivers simpler and more robust. The amount of really dumb driver boiler plate that this series obviously removes is exactly the sort of stuff we should be fixing by improving the core code. The callback interface was never really sanely designed, it was just built around the idea of pulling the timout processing into the core code for TIS hardware. It should be revised to properly match these new HW types that don't have this kind of timeout mechanism. Jason