From: Frank Li <Frank.li@nxp.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"open list:PCI ENDPOINT SUBSYSTEM" <linux-pci@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] misc: pci_endpoint_test: Set .driver_data for PCI_DEVICE_ID_IMX8
Date: Tue, 1 Apr 2025 09:56:12 -0400 [thread overview]
Message-ID: <Z+vwfHOLIej1gjsL@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <Z-u__47R9vprIbCS@ryzen>
On Tue, Apr 01, 2025 at 12:29:19PM +0200, Niklas Cassel wrote:
> On Tue, Apr 01, 2025 at 12:05:37PM +0200, Niklas Cassel wrote:
> >
> > But... I suggest that we just remove the pci_endpoint_test_alloc_irq_vectors()
> > call from pci_endpoint_test_probe().
>
> ...
>
> Solution 1.
>
>
> >
> > Or, if we want to keep allocating some kind of IRQ vector in probe(),
> > just to rule out totally broken platforms, I guess we could also do:
>
> ...
>
> Solution 2.
>
>
>
> Considering that this is a test driver, I actually think Solution 1 is better.
> That way, even if the platform has issues with IRQs, the user can do still do
> all the tests/ioctls() that do not require working IRQs, e.g. PCITEST_BAR and
> PCITEST_BARS.
Can you post patch directly, so I can test it.
Frank
>
>
> Kind regards,
> Niklas
prev parent reply other threads:[~2025-04-01 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 18:29 Frank Li
2025-04-01 10:05 ` Niklas Cassel
2025-04-01 10:29 ` Niklas Cassel
2025-04-01 13:56 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+vwfHOLIej1gjsL@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=arnd@arndb.de \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=imx@lists.linux.dev \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®