From: Christoph Hellwig <hch@infradead.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fs: make generic_fillattr() tail-callable and utilize it in ext2/ext4
Date: Fri, 4 Apr 2025 01:33:58 -0700 [thread overview]
Message-ID: <Z--ZdiXwzCBskXQK@infradead.org> (raw)
In-Reply-To: <20250401165252.1124215-1-mjguzik@gmail.com>
On Tue, Apr 01, 2025 at 06:52:52PM +0200, Mateusz Guzik wrote:
> Unfortunately the other filesystems I checked make adjustments after
> their own call to generic_fillattr() and consequently can't benefit.
This is in no way a useful commit message.
Why do you even do this change? What's the point of it? And why do you
think making a function tail callable for two callers, one of which is
basically irrelevant warrants adding a pointless return that now needs
to be generated and checked by all other callers (which this patch fails
to do)?
next prev parent reply other threads:[~2025-04-04 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 16:52 Mateusz Guzik
2025-04-03 8:43 ` Christian Brauner
2025-04-04 8:33 ` Christoph Hellwig [this message]
2025-04-04 20:14 ` Mateusz Guzik
2025-04-07 8:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z--ZdiXwzCBskXQK@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®