From: Christoph Hellwig <hch@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Penglei Jiang <superman.xpt@gmail.com>,
viro@zeniv.linux.org.uk, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+5d8e79d323a13aa0b248@syzkaller.appspotmail.com
Subject: Re: [PATCH 2/2] vfs: Fix anon_inode triggering VFS_BUG_ON_INODE in may_open()
Date: Fri, 4 Apr 2025 01:47:12 -0700 [thread overview]
Message-ID: <Z--ckIgXpv_-tE1l@infradead.org> (raw)
In-Reply-To: <20250404-kammer-fahrrad-516fe910491e@brauner>
On Fri, Apr 04, 2025 at 10:45:43AM +0200, Christian Brauner wrote:
> On Fri, Apr 04, 2025 at 01:31:58AM -0700, Christoph Hellwig wrote:
> > Please make sure anon inodes have a valid mode set. Leaving this
> > landmine around where we have inodes without a valid mode is just going
> > to create more problems in the future.
>
> We've tried to change it, it immediately leads to userspace tools
> regressions as they've started to rely on that behavior because it's been
> like that since the dawn of time. We even had to work around that crap
> in pidfs because lsof regressed. So now, we can't do this.
Just because i_mode has something useful, we don't need to report that
to userspace. We can still clear kstat.mode (with a big fat comment
explaining why).
next prev parent reply other threads:[~2025-04-04 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 1:59 Penglei Jiang
2025-04-03 2:26 ` Mateusz Guzik
2025-04-04 3:29 ` [PATCH v2] " Penglei Jiang
2025-04-04 5:14 ` Mateusz Guzik
2025-04-04 8:31 ` [PATCH 2/2] " Christoph Hellwig
2025-04-04 8:45 ` Christian Brauner
2025-04-04 8:47 ` Christoph Hellwig [this message]
2025-04-04 9:09 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z--ckIgXpv_-tE1l@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=superman.xpt@gmail.com \
--cc=syzbot+5d8e79d323a13aa0b248@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®