Re: [GIT PULL] more printk for 6.15

[Andy Shevchenko <andy.shevchenko@gmail.com>]

Wed, Apr 02, 2025 at 10:12:27AM -0700, Linus Torvalds kirjoitti:
> On Wed, 2 Apr 2025 at 05:58, Petr Mladek <pmladek@suse.com> wrote:
> >
> > please pull few more printk-related changes from
> 
> Pulled. However, I reacted to this mess:

Yeah, this is the most plausible solution (rather workaround) proposed by
Rasmus. He thinks that GCC fails to recognize that va_format() is not what it
thinks it is.

>   +#pragma GCC diagnostic push
>   +#ifndef __clang__
>   +#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>   +#endif
> 
> do we really need a "#ifndef __clang__" there? It's "#pragma GCC"
> after all, and the diagnostic push/pop are done unconditionally.

Yes. Clang complains on unknown pragma.

> I can well imagine that yes, we need it for some strange and stupid
> reason, but it looks wrong, and the commit message doesn't explain why
> we'd need it.

Ah, sorry, since Rasmus said something like "and add necessary magic to make
clang work" I mistakenly assumed that's kinda obvious that this is GCC only
stuff.

> And once again the "Link" is completely useless and doesn't point to
> any explanation, only points to the submission that has all the same
> info.

The problem with (automatic) Link tag is that it points to the latest version
of the patch where all of the discussion have been settled down. And more (but
maybe not full) information is available on the previous versions. The fix
would be to have some kind of version tracking system for the series (oh,
sounds like Gerrit :).

> I hate those things. The disappointment is real: "Oh, an explanation"
> followed by "No, just useless noise, doing a google search would
> almost certainly have been more productive".

-- 
With Best Regards,
Andy Shevchenko