From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19D41E1E13 for ; Mon, 31 Mar 2025 11:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743419499; cv=none; b=BU4nyGGGAefsP+5dIHEIT4V0pNY8ydNg+HAx/sh47rVFCO1Epk0rqXv9oGiex5jKjpmnOLm94Cy4lkfanhFUq/ugivC4QUz3B20DISokzGSmGOhLoiTo20bNz/RPjtKrBPNmQKAh7UaIK/qeD/Tf0QsydZNrWhRQ4QKACF7SVU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743419499; c=relaxed/simple; bh=bQvxaj99iKc9Prh5cmtyf4pcZBD8XtodfthaYAnrzqg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ttLjIzdgNhLCCGAo3SQGU2nkJuBXSk0K4Tzp6nDABcA+3jwHykukvis2uF2nL7xScOFaPpzvWpHfLmis4Sl5wi/fRAd3xSMTQzlTw+AXpv0wKoQbxZeHVqidBT35a5nqaK+YeUS4Ygn7ZpxOmqhyhw1ORIdYP2OoJa66jCds7rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=vI1nH82f; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="vI1nH82f" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-39c1efbefc6so194226f8f.1 for ; Mon, 31 Mar 2025 04:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1743419496; x=1744024296; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A/z9KaeViB+nABb+i0f3FPF1rJaPqOeT5WIFGvfG0zY=; b=vI1nH82fHnBbiYc3zwyDDW6ktusaYpVukZlitKv1Zz47qrTBB/ZGhoDb3W5V8R+DKl 71Y89xmA+ow4E2I1kibEEREy52NDffzJ9G7VJENloJdJtChGVRYpdThatvZNNd0wVaH7 r9uxQOUSIQafYmdEN4c5/6RHQY/9+gRhBa8Mav2hS6BOyA4xdutssdkpmVDQM3RjeIDJ KyZp5guxTi78K0HNsMYpJW+e26TwYg9rNMwx9fru6GVVfhuQz9ZRFPAQFFBxmLFtSU90 5rAMiUjr9hq6xxOiFjqHwXOdqs5u/9lSvFLC2I1kqXhQa4v3Zva2hLX7pyIgDdYb8Qse Ytdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743419496; x=1744024296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A/z9KaeViB+nABb+i0f3FPF1rJaPqOeT5WIFGvfG0zY=; b=iPa0LUoQTtVKCsqhyDhfEQ6R4iOsdG40zWUP7XREXwV20iIh6C653Quf3Tv38k8Luu o1eK9bZGnP4zHI7zWOTdeKMLv4EwjGzyBrGl0r0si0EKxO4Ix70Um2a2iC6ILb2mDund b1EIB8KNasD8uBuJkUrtfgD4s4/FEWccp4R8m05j2Bs/rfLHs1sOlEZLbXk+qp616RhO 2GZMMTr5lbMjUc6Zrc+fAowoIufOekwaZ+ePIdcq5yfMv9KjN1esw4U+hjLbDVW0HJHv xuePS8HVqjQmAUIzUcuTLTvRyCbvbZOUOM5aVncaVVf+KpwhqqO42GAyc/rkGxFPrHB2 4atQ== X-Forwarded-Encrypted: i=1; AJvYcCWUzhzUYBJYVAJgHx9nUWdxc/fieHiniMbFrMd1vqiXDHw9A9M45uDcqhCnSgtCSDPV9bgktoAlE7UNRbc=@vger.kernel.org X-Gm-Message-State: AOJu0YwSG0neM8EAzwqXGfC3z8Qk1wC0d6hCzi7dHpMLeYmfBZ1QJ/nx wZb+kyen17z8xGZmhe5iej28U6OX0R6SwkElb71GD8FSZYE+LtjntlHrm+X75Ms= X-Gm-Gg: ASbGncvHkSJQ6N52aQFpLLJBnc7beVyy4uAHe4R8EgRtenM/zgg37llyCetbARIzRvl HE94buntYErnUfs76HwkVQWo65XxczcYCJskM8HCMlcBH1GHICHC2TFLzaz/PVODlfJKxRv8CV7 MuyVm+C5mO07qJ5W/owBGfWWlm9JZb90pz2smAYffYVfyxRfFSWgMcqV+V4MY1bdZwhbZf0kuwR pOLzjsKjlhfUFk999TT/Go0Zwj2t3dOPmduieqrX/zKCJob5mz18dMPvhLsrpEGpddTX4BymX25 4Fpxvg1PrwGZSBaSfawbcaY60Gmw5qdiEAFUm472IcGn3yS2QQ0v6jtwAHPpbrqoH1eGym0Sdhl Oyb7AWVReMt7lgh36p2felFYqkvYfu31lcHiP7Q== X-Google-Smtp-Source: AGHT+IHbzgndrMf5AmHgtnob+9Zffklj+mzgcK1rt8g4VD0vaNiQLwfQIes1v+pMENrKBCJDAmITYA== X-Received: by 2002:a05:6000:2d10:b0:38f:23f4:2d7a with SMTP id ffacd0b85a97d-39c12117dc4mr4659354f8f.40.1743419495944; Mon, 31 Mar 2025 04:11:35 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82efdff2sm161702445e9.17.2025.03.31.04.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 04:11:34 -0700 (PDT) Date: Mon, 31 Mar 2025 12:11:32 +0100 From: Daniel Thompson To: Henry Martin Cc: lee@kernel.org, danielt@kernel.org, jingoohan1@gmail.com, deller@gmx.de, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: qcom-wled: Add NULL check in the wled_configure Message-ID: References: <20250331091245.6668-1-bsdhenrymartin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250331091245.6668-1-bsdhenrymartin@gmail.com> On Mon, Mar 31, 2025 at 05:12:45PM +0800, Henry Martin wrote: > When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function wled_configure. > > A NULL check should be added after the devm_kasprintf call to prevent potential NULL pointer dereference error. > > Fixes: f86b77583d88c ("backlight: pm8941: Convert to using %pOFn instead of device_node.name") > > Signed-off-by: Henry Martin > --- > drivers/video/backlight/qcom-wled.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index 9afe701b2a1b..db5eda8ec37e 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -1406,8 +1406,14 @@ static int wled_configure(struct wled *wled) > wled->ctrl_addr = be32_to_cpu(*prop_addr); > > rc = of_property_read_string(dev->of_node, "label", &wled->name); > - if (rc) > + if (rc) { > wled->name = devm_kasprintf(dev, GFP_KERNEL, "%pOFn", dev->of_node); > + if (!wled->name) { > + dev_err(dev, "Failed to allocate memory for wled name\n"); > + return -ENOMEM; > + } > + } > + No objections to the check but I don't think it needs a dev_err(). It is a waste of .text to store a string that is likely never to be printed. Daniel.