From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46166CDBA; Fri, 22 Nov 2024 08:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732262476; cv=none; b=M+5IXSMM+gsFbLoebxqBnqCjunoWDNsvPT+wQbkCAnLrlUq6EeIjztAUetLLxrkoMsZFgk/Mt7JvtdfuvnTvxnANwu+DG0H0n5J57s37tCoeBGbiqyf7xzfULa8UtTlAlkD2lrOv/4bZHOVKv2+pFmPw9fUE/akbF2DfgF2cce4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732262476; c=relaxed/simple; bh=SI+Dvo5fG2wGvmS/CiWJVZivtu+gHtApg0XMcvj/EyY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dIM7E9P6GoMZB4A4420A3qPFkFiYddFzI/pqP1Cbv1DDXhjA346D+wrTEU4oHxggyWlVYKlttvTPRqhXWb2ecZgfxPY9FKp0AuFCP9ge+7Mub1rcLxnbWcZVMFWwjZI0bBglOKy8iuA47bn++sfPN1aTkkIOxTtqhyuTIAdRgJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Z1gyijaH; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Z1gyijaH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732262475; x=1763798475; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SI+Dvo5fG2wGvmS/CiWJVZivtu+gHtApg0XMcvj/EyY=; b=Z1gyijaHxWQ7Nr096KAPNJ1ZpNvueQNh/7w36Po3szcNBHwGpZIYNpmq kLPOytDiJk4ywWhGggkRoJx5co+aggmtOpjrAhoZZm11E/598jvxbPenZ IxWOT9/rcGROofzgRuZ5oudC3SEKNvFKUfUjrKjaLPCIvvTxx1OpnfiF6 gD4PjxiJAQk6Kxzx+IvmahZ5FQsq1TV9aBcWK2MXs0e+YwQFzSpit+tf9 PCiw5KyCAZZCLX+si9GZ1ssf6YMJ87ndF36eLPKE/2+makyNZhP9cTS2a Bt/PzN4fUU9ahbpdLpnNAYkPGolfGBBzbGrXaocDorBpnbJDkcqCXjdYA Q==; X-CSE-ConnectionGUID: xzZXJIp6RsOtFckTfQYONA== X-CSE-MsgGUID: 72MIC3aZQ2mzovIfpVDFBA== X-IronPort-AV: E=McAfee;i="6700,10204,11263"; a="31799382" X-IronPort-AV: E=Sophos;i="6.12,175,1728975600"; d="scan'208";a="31799382" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2024 00:01:14 -0800 X-CSE-ConnectionGUID: l+o41oNARJi79iIwRknaiQ== X-CSE-MsgGUID: GWB/6Qo0TbOl1iE4ZT80OQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,175,1728975600"; d="scan'208";a="90142818" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2024 00:01:12 -0800 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 72C3711F7E7; Fri, 22 Nov 2024 10:01:09 +0200 (EET) Date: Fri, 22 Nov 2024 08:01:09 +0000 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Sakari Ailus To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, Ricardo Ribalda , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented Message-ID: References: <54307d9c-a9bf-4bc1-b15d-60c5ba53d0ea@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54307d9c-a9bf-4bc1-b15d-60c5ba53d0ea@stanley.mountain> Hi Dan, On Fri, Nov 22, 2024 at 10:45:53AM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 28eb75e178d389d325f1666e422bc13bbbb9804c > commit: 93da10eee90b2ffa4b496dd4a6ea276c57461fb6 media: intel/ipu6: Fix direct dependency Kconfig error > config: alpha-randconfig-r072-20241122 (https://download.01.org/0day-ci/archive/20241122/202411221147.N6w23gDo-lkp@intel.com/config) > compiler: alpha-linux-gcc (GCC) 14.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202411221147.N6w23gDo-lkp@intel.com/ > > smatch warnings: > drivers/media/pci/intel/ipu-bridge.c:752 ipu_bridge_ivsc_is_ready() warn: iterator 'i' not incremented > > vim +/i +752 drivers/media/pci/intel/ipu-bridge.c > > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 745 static int ipu_bridge_ivsc_is_ready(void) > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 746 { > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 747 struct acpi_device *sensor_adev, *adev; > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 748 struct device *csi_dev; > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 749 bool ready = true; > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 750 unsigned int i; > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 751 > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 @752 for (i = 0; i < ARRAY_SIZE(ipu_supported_sensors); i++) { > 8810e055b57543 drivers/media/pci/intel/ipu-bridge.c Ricardo Ribalda 2024-05-01 753 #if IS_ENABLED(CONFIG_ACPI) > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 754 const struct ipu_sensor_config *cfg = > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 755 &ipu_supported_sensors[i]; > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 756 > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 757 for_each_acpi_dev_match(sensor_adev, cfg->hid, NULL, -1) { > 8810e055b57543 drivers/media/pci/intel/ipu-bridge.c Ricardo Ribalda 2024-05-01 758 #else > 8810e055b57543 drivers/media/pci/intel/ipu-bridge.c Ricardo Ribalda 2024-05-01 759 while (true) { > ^^^^^^^^^^^^^^ > > 8810e055b57543 drivers/media/pci/intel/ipu-bridge.c Ricardo Ribalda 2024-05-01 760 sensor_adev = NULL; > 8810e055b57543 drivers/media/pci/intel/ipu-bridge.c Ricardo Ribalda 2024-05-01 761 #endif > 8810e055b57543 drivers/media/pci/intel/ipu-bridge.c Ricardo Ribalda 2024-05-01 762 if (!ACPI_PTR(sensor_adev->status.enabled)) > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 763 continue; > > > These continues make sense in for_each_acpi_dev_match() but not in a while (true) { > loop. We're stuck forever. The non-ACPI case is there just for the looks... I think what should be done is to make the entire loop conditional to CONFIG_ACPI. I can post a patch. > > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 764 > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 765 adev = ipu_bridge_get_ivsc_acpi_dev(sensor_adev); > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 766 if (!adev) > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 767 continue; > ^^^^^^^^ > > > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 768 > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 769 csi_dev = ipu_bridge_get_ivsc_csi_dev(adev); > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 770 if (!csi_dev) > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 771 ready = false; > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 772 > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 773 put_device(csi_dev); > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 774 acpi_dev_put(adev); > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 775 } > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 776 } > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 777 > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 778 return ready; > c66821f381aed2 drivers/media/pci/intel/ipu-bridge.c Wentong Wu 2023-08-03 779 } > -- Kind regards, Sakari Ailus