From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 770F11714CF for ; Sun, 24 Nov 2024 09:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732441785; cv=none; b=EGCzdKomZGMn9g9981+cq1xduaGZbOlRo5ganRb9FJmYa3vT3VuoPVdEhTtFF81nziROKudlE1a46qaQ3AbzQPwh79KbpAnCcFiLpFs1/cqvIc2AxT/JRGsVvfaroN75kvJFduBLLfUN+wZGOtnvyFXR8+MrNR933AMjMMFKsYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732441785; c=relaxed/simple; bh=VQjlZzpEPLSHhJ+LVVkeqa2lj7Tm8/9zXD5QsVtxOEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DO9W9aeT3XQlVb09uqJgmkZBqBzdDhpABbC6z+ROjy/gpbDfoeqZJrwLD74QYjJPWtrRklgzWggxLIYRbTS7UA9lPYHs0x5fW/jD6GPsa5VHEa1MNAC+7uSHdiJqe3ZmQ05I1h0RV15FZqi5/ZO3tbphWogk9uOsykr3nO8alkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tF9FD-0005zL-Kf; Sun, 24 Nov 2024 10:49:31 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tF9FD-002ND9-0Y; Sun, 24 Nov 2024 10:49:31 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tF9FD-00CgUp-09; Sun, 24 Nov 2024 10:49:31 +0100 Date: Sun, 24 Nov 2024 10:49:31 +0100 From: Oleksij Rempel To: Kory Maincent Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Donald Hunter , Rob Herring , Andrew Lunn , Simon Horman , Heiner Kallweit , Russell King , Liam Girdwood , Mark Brown , Thomas Petazzoni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, Kyle Swenson , Dent Project , kernel@pengutronix.de, Maxime Chevallier Subject: Re: [PATCH RFC net-next v3 18/27] net: pse-pd: Fix missing PI of_node description Message-ID: References: <20241121-feature_poe_port_prio-v3-0-83299fa6967c@bootlin.com> <20241121-feature_poe_port_prio-v3-18-83299fa6967c@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241121-feature_poe_port_prio-v3-18-83299fa6967c@bootlin.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Thu, Nov 21, 2024 at 03:42:44PM +0100, Kory Maincent wrote: > From: Kory Maincent (Dent Project) > > The PI of_node was not assigned in the regulator_config structure, leading > to failures in resolving the correct supply when different power supplies > are assigned to multiple PIs of a PSE controller. This fix ensures that the > of_node is properly set in the regulator_config, allowing accurate supply > resolution for each PI. > > Signed-off-by: Kory Maincent Acked-by: Oleksij Rempel > --- > > Changes in v3: > - New patch > --- > drivers/net/pse-pd/pse_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c > index 8b5a9e7fd9c5..d4cf5523194d 100644 > --- a/drivers/net/pse-pd/pse_core.c > +++ b/drivers/net/pse-pd/pse_core.c > @@ -419,6 +419,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev, > rconfig.dev = pcdev->dev; > rconfig.driver_data = pcdev; > rconfig.init_data = rinit_data; > + rconfig.of_node = pcdev->pi[id].np; > > rdev = devm_regulator_register(pcdev->dev, rdesc, &rconfig); > if (IS_ERR(rdev)) { > > -- > 2.34.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |