mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, festevam@gmail.com,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
	daniel.baluta@gmail.com, laurentiu.mihalcea@nxp.com,
	shengjiu.wang@nxp.com, iuliana.prodan@nxp.com,
	a.fatoum@pengutronix.de
Subject: Re: [PATCH v2 4/6] dt-bindings: clock: imx8mp: Add syscon compatible
Date: Mon, 25 Nov 2024 12:08:39 -0500	[thread overview]
Message-ID: <Z0SvF2tQR14jrHet@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20241125152427.136883-5-daniel.baluta@nxp.com>

On Mon, Nov 25, 2024 at 05:24:24PM +0200, Daniel Baluta wrote:
> imx8mp audiomix contains a set of registers used to control
> the DSP.
>
> The dsp will use this to acquire o reference to audiomix registers
> and handle the registers to control the dsp.

Look like this is NOT good method to direct operate these register. If it
is reset, you should export it as reset interface. If it is clock, you
should export it as clock interface.

Frank

>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
> index 6588a17a7d9a..f368682f3633 100644
> --- a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
> @@ -15,7 +15,9 @@ description: |
>
>  properties:
>    compatible:
> -    const: fsl,imx8mp-audio-blk-ctrl
> +    items:
> +      - const: fsl,imx8mp-audio-blk-ctrl
> +      - const: syscon
>
>    reg:
>      maxItems: 1
> --
> 2.43.0
>

  parent reply	other threads:[~2024-11-25 17:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 15:24 [PATCH v2 0/6] Configure imx8mp dsp node for rproc usage Daniel Baluta
2024-11-25 15:24 ` [PATCH v2 1/6] arm64: dts: imx8mp: Add mu2 root clock Daniel Baluta
2024-11-25 15:24 ` [PATCH v2 2/6] arm64: dts: imx8mp: Configure dsp node for rproc usage Daniel Baluta
2024-11-25 15:24 ` [PATCH v2 3/6] arm64: dts: imx8mp: Add DSP clocks Daniel Baluta
2024-11-25 15:24 ` [PATCH v2 4/6] dt-bindings: clock: imx8mp: Add syscon compatible Daniel Baluta
2024-11-25 16:25   ` Rob Herring (Arm)
2024-11-25 17:08   ` Frank Li [this message]
2024-11-26 15:31     ` Daniel Baluta
2024-11-26 16:36       ` Frank Li
2024-11-25 15:24 ` [PATCH v2 5/6] arm64: dts: imx8mp: Add fsl,dsp-ctrl property for dsp Daniel Baluta
2024-11-25 15:24 ` [PATCH v2 6/6] arm64: dts: Add dsp rproc related mem regions Daniel Baluta
2024-11-26  6:49   ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0SvF2tQR14jrHet@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=aisheng.dong@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=iuliana.prodan@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=laurentiu.mihalcea@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®