mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	samitolvanen@google.com, petr.pavlu@suse.com,
	da.gomez@samsung.com, linux-modules@vger.kernel.org,
	patches@lists.linux.dev, linux-kernel@vger.kernel.org,
	mmaurer@google.com, arnd@arndb.de, deller@gmx.de,
	song@kernel.org
Subject: Re: [GIT PULL] Modules changes for v6.13-rc1
Date: Wed, 27 Nov 2024 18:38:42 -0800	[thread overview]
Message-ID: <Z0fXshsZI8J0NhQo@bombadil.infradead.org> (raw)
In-Reply-To: <CAK7LNAQyhxPZfpK3hVPtYvCYjad4pTUim5jVsEsuXqefY8KhWQ@mail.gmail.com>

On Thu, Nov 28, 2024 at 11:09:43AM +0900, Masahiro Yamada wrote:
> diff --git a/lib/tests/module/Makefile b/lib/tests/module/Makefile
> index af5c27b996cb..8cfc4ae600a9 100644
> --- a/lib/tests/module/Makefile
> +++ b/lib/tests/module/Makefile
> @@ -3,13 +3,12 @@ obj-$(CONFIG_TEST_KALLSYMS_B) += test_kallsyms_b.o
>  obj-$(CONFIG_TEST_KALLSYMS_C) += test_kallsyms_c.o
>  obj-$(CONFIG_TEST_KALLSYMS_D) += test_kallsyms_d.o
> 
> -$(obj)/%.c: FORCE
> -       @$(kecho) "  GEN     $@"
> -       $(Q)$(srctree)/lib/tests/module/gen_test_kallsyms.sh $@\
> -               $(CONFIG_TEST_KALLSYMS_NUMSYMS) \
> -               $(CONFIG_TEST_KALLSYMS_SCALE_FACTOR)
> +quiet_cmd_gen_test_kallsyms = GEN     $@
> +      cmd_gen_test_kallsyms = $< $@ \
> +       $(CONFIG_TEST_KALLSYMS_NUMSYMS) \
> +       $(CONFIG_TEST_KALLSYMS_SCALE_FACTOR)
> 
> -clean-files += test_kallsyms_a.c
> -clean-files += test_kallsyms_b.c
> -clean-files += test_kallsyms_c.c
> -clean-files += test_kallsyms_d.c
> +$(obj)/%.c: $(src)/gen_test_kallsyms.sh FORCE

Thanks! We can also just replace the FORCE with $(KCONFIG_CONFIG), no?

  Luis

  reply	other threads:[~2024-11-28  2:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27  1:10 Luis Chamberlain
2024-11-27 18:33 ` pr-tracker-bot
2024-11-27 21:22 ` Linus Torvalds
2024-11-27 22:35   ` Luis Chamberlain
2024-11-27 23:26     ` Luis Chamberlain
2024-11-27 23:56       ` Linus Torvalds
2024-11-28  2:09         ` Masahiro Yamada
2024-11-28  2:38           ` Luis Chamberlain [this message]
2024-11-28  2:48             ` Masahiro Yamada
2024-11-28  2:22         ` Luis Chamberlain
2024-11-28  2:42           ` Luis Chamberlain
2024-11-28  2:56             ` Masahiro Yamada
2024-11-28  3:02               ` Luis Chamberlain
2024-11-28  3:10                 ` Luis Chamberlain
2024-11-28  3:14                   ` Masahiro Yamada
2024-11-28  3:12                 ` Masahiro Yamada
2024-11-28  2:44           ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0fXshsZI8J0NhQo@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=arnd@arndb.de \
    --cc=da.gomez@samsung.com \
    --cc=deller@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mmaurer@google.com \
    --cc=patches@lists.linux.dev \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=song@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®