From: Steffen Klassert <steffen.klassert@secunet.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Ilia Lin <ilia.lin@kernel.org>, <herbert@gondor.apana.org.au>,
"David Miller" <davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<horms@kernel.org>, <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xfrm: Add pre-encap fragmentation for packet offload
Date: Thu, 28 Nov 2024 10:25:23 +0100 [thread overview]
Message-ID: <Z0g3A87ArEdrOCgj@gauss3.secunet.de> (raw)
In-Reply-To: <20241126132145.GA1245331@unreal>
On Tue, Nov 26, 2024 at 03:21:45PM +0200, Leon Romanovsky wrote:
> On Tue, Nov 26, 2024 at 01:59:31PM +0100, Steffen Klassert wrote:
> > On Tue, Nov 26, 2024 at 10:35:13AM +0200, Leon Romanovsky wrote:
> > >
> > > Steffen, do we need special case for packet offload here? My preference is
> > > to make sure that we will have as less possible special cases for packet
> > > offload.
> >
> > Looks like the problem on packet offload is that packets
> > bigger than MTU size are dropped before the PMTU signaling
> > is handled.
>
> But PMTU should be less or equal to MTU, even before first packet was
> sent. Otherwise already first packet will be fragmented.
Atually I ment PMTU. On packet offload, we just drop packets bigger
than PMTU. We need to make sure that xfrm{4,6}_tunnel_check_size
is called. This will either fragment or do PMTU signaling.
next prev parent reply other threads:[~2024-11-28 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 9:35 Ilia Lin
2024-11-24 12:04 ` Leon Romanovsky
2024-11-25 9:26 ` Ilia Lin
2024-11-25 19:43 ` Leon Romanovsky
2024-11-26 7:48 ` Ilia Lin
[not found] ` <CA+5LGR0e677wm5zEx9yYZDtsCUL6etMoRB2yF9o5msqdVOWU8w@mail.gmail.com>
2024-11-26 8:35 ` Leon Romanovsky
2024-11-26 12:59 ` Steffen Klassert
2024-11-26 13:21 ` Leon Romanovsky
2024-11-28 9:25 ` Steffen Klassert [this message]
2024-11-28 12:14 ` Leon Romanovsky
2024-11-26 12:51 ` Steffen Klassert
2024-11-26 13:22 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0g3A87ArEdrOCgj@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=ilia.lin@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®